Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix make extract #9152

Merged
merged 2 commits into from
Sep 9, 2020
Merged

fix make extract #9152

merged 2 commits into from
Sep 9, 2020

Conversation

zhijianli88
Copy link
Contributor

$ make extract
go run cmd/extract/extract.go
panic: err_map.go doesn't exist

goroutine 1 [running]:
main.main()
/home/lizj/workspace/k8s/minikube/cmd/extract/extract.go:47 +0x1b4
exit status 2
Makefile:304: recipe for target 'extract' failed
make: *** [extract] Error 1

Fixes #9126
Signed-off-by: Li Zhijian [email protected]

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 2, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @zhijianli88. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhijianli88
To complete the pull request process, please assign josedonizetti
You can assign the PR to them by writing /assign @josedonizetti in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@tstromberg
Copy link
Contributor

err_map.go is not gone, it was just renamed in a recent refactor:

https://github.com/kubernetes/minikube/blob/master/pkg/minikube/reason/known_issues.go

Do you mind changing the code to use the new path to the file rather than removing the feature?

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 2, 2020
@zhijianli88
Copy link
Contributor Author

err_map.go is not gone, it was just renamed in a recent refactor:

https://github.com/kubernetes/minikube/blob/master/pkg/minikube/reason/known_issues.go

Do you mind changing the code to use the new path to the file rather than removing the feature?

Yeap! thank you

> err_map.go is not gone, it was just renamed in a recent refactor:
> https://github.com/kubernetes/minikube/blob/master/pkg/minikube/reason/known_issues.go

$ make extract
go run cmd/extract/extract.go
panic: err_map.go doesn't exist

goroutine 1 [running]:
main.main()
	/home/lizj/workspace/k8s/minikube/cmd/extract/extract.go:47 +0x1b4
exit status 2
Makefile:304: recipe for target 'extract' failed
make: *** [extract] Error 1

Fixes #9126
Signed-off-by: Li Zhijian <[email protected]>
$ make extract
go run cmd/extract/extract.go
Compiling translation strings...
Writing to de.json (53 translated, 671 untranslated)
Writing to es.json (53 translated, 671 untranslated)
Writing to fr.json (67 translated, 657 untranslated)
Writing to ja.json (295 translated, 429 untranslated)
Writing to ko.json (143 translated, 581 untranslated)
Writing to pl.json (85 translated, 639 untranslated)
Writing to zh-CN.json (221 translated, 503 untranslated)
Done!

Signed-off-by: Li Zhijian <[email protected]>
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@medyagh
Copy link
Member

medyagh commented Sep 9, 2020

thank you @zhijianli88

@medyagh medyagh merged commit ef7e7e8 into kubernetes:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants