-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix make extract #9152
fix make extract #9152
Conversation
Hi @zhijianli88. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zhijianli88 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
err_map.go is not gone, it was just renamed in a recent refactor: Do you mind changing the code to use the new path to the file rather than removing the feature? |
Yeap! thank you |
> err_map.go is not gone, it was just renamed in a recent refactor: > https://github.com/kubernetes/minikube/blob/master/pkg/minikube/reason/known_issues.go $ make extract go run cmd/extract/extract.go panic: err_map.go doesn't exist goroutine 1 [running]: main.main() /home/lizj/workspace/k8s/minikube/cmd/extract/extract.go:47 +0x1b4 exit status 2 Makefile:304: recipe for target 'extract' failed make: *** [extract] Error 1 Fixes #9126 Signed-off-by: Li Zhijian <[email protected]>
$ make extract go run cmd/extract/extract.go Compiling translation strings... Writing to de.json (53 translated, 671 untranslated) Writing to es.json (53 translated, 671 untranslated) Writing to fr.json (67 translated, 657 untranslated) Writing to ja.json (295 translated, 429 untranslated) Writing to ko.json (143 translated, 581 untranslated) Writing to pl.json (85 translated, 639 untranslated) Writing to zh-CN.json (221 translated, 503 untranslated) Done! Signed-off-by: Li Zhijian <[email protected]>
Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
thank you @zhijianli88 |
$ make extract
go run cmd/extract/extract.go
panic: err_map.go doesn't exist
goroutine 1 [running]:
main.main()
/home/lizj/workspace/k8s/minikube/cmd/extract/extract.go:47 +0x1b4
exit status 2
Makefile:304: recipe for target 'extract' failed
make: *** [extract] Error 1
Fixes #9126
Signed-off-by: Li Zhijian [email protected]