Remove conflicting & inaccurate Docker Desktop memory warning

[tstromberg]

I propose we remove this warning for a couple of reasons:

• The 3GB recommendation here conflicts with the 2.25 GB recommendation we make 18 lines above it.

• This puts us in an awkward position of providing conflicting advice: we first ask the user to increase to 2.25GB, then we warn that they haven't increased it to 3GB

• I have observed no performance degradation with 2GB of memory. Intuitively, with the exception of OOM pressure, the amount of memory has little measurable effect on Kubernetes performance. I would be willing to accept measurements that disprove this assertion, however.

• If there was a warning to be made here, there is nothing that should make it a Docker Desktop specific warning

• For people who intentionally allocate only 2GB of memory, the warning is noisy and there is no way to turn it off.

Fixes #8892

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tstromberg]

I did think of one scenario where this could possibly be an accurate warning: an unexpected swap behavior?

It's possible to trigger a swapping scenario with 1GB of memory usage:

docker@minikube:~$ free
              total        used        free      shared  buff/cache   available
Mem:        1008588      665576       60520        1984      282492      200532
Swap:        524284      160768      363516

With 2GB, it's more modest. It seems like we should just turn off swap altogether for Docker.

              total        used        free      shared  buff/cache   available
Mem:        2039264      802480       96580        8476     1140204     1077124
Swap:        524284       18004      506280

[tstromberg]

Sent out a separate PR to fix the underlying swap performance issue that caused this warning to be emitted in the first place.