Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: Remove use of deprecated ComponentStatusList API #9058

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

tstromberg
Copy link
Contributor

Fixes issues with the deprecated usage of ComponentStatusList seen in #9050

For more context, see https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.19.md

Sample output:

=== CONT  TestFunctional/parallel/ComponentHealth
    functional_test.go:322: (dbg) Run:  kubectl --context minikube get po -l tier=control-plane -n kube-system -o=json
    functional_test.go:334: etcd phase: Running
    functional_test.go:334: control-plane phase: Running
    functional_test.go:334: kube-apiserver phase: Running
    functional_test.go:334: control-plane phase: Running
    functional_test.go:334: kube-controller-manager phase: Running
    functional_test.go:334: control-plane phase: Running
    functional_test.go:334: kube-scheduler phase: Running
    functional_test.go:334: control-plane phase: Running
--- PASS: TestFunctional (0.12s)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 21, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 21, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9058): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9058/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9058/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9058): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9058/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9058/minikube: exec format error

@tstromberg
Copy link
Contributor Author

/ok-to-test

@tstromberg tstromberg merged commit 59af2c1 into kubernetes:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants