skip validations if --force is supplied #8969

priyawadhwa · 2020-08-11T18:17:09Z

This will fix a cloud shell bug

output now:

$ minikube start --driver docker --download-only --force
😄  minikube v1.12.2 on Darwin 10.14.6
❗  minikube skips various validations when --force is supplied; this may lead to unexpected behavior
✨  Using the docker driver based on existing profile
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
✅  Download complete!

priyawadhwa · 2020-08-11T18:17:24Z

/ok-to-test

k8s-ci-robot · 2020-08-11T18:17:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [priyawadhwa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-pr-bot · 2020-08-11T18:40:47Z

kvm2 Driver
Times for minikube: [65.443924349 59.961347512 59.104136405]
Average time for minikube: 61.50313608866667

Times for Minikube (PR 8969): [60.941701728000005 59.79701377799999 62.870484757]
Average time for Minikube (PR 8969): 61.20306675433333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8969) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.2 on Debian   |  0.057210 |           0.057982 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.021985 |           0.020343 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.004286 |           0.003079 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 38.184452 |          39.494178 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 21.792397 |          20.082626 |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.317970 |           1.221725 |
| components...                  |           |                    |
| * Enabled addons:              |  0.039829 |           0.247389 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.080662 |           0.071487 |
| configured to use "minikube"   |           |                    |
|                                |  0.004346 |           0.004257 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.134809651999998 27.13173988 27.666512581]
Average time for minikube: 27.311020704333334

Times for Minikube (PR 8969): [26.600051089 26.999339037000002 26.065668697000003]
Average time for Minikube (PR 8969): 26.55501960766667

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8969) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.2 on Debian   |  0.070907 |           0.071621 |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.096544 |           0.101513 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.062760 |           0.054747 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    |  8.471871 |           8.496621 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 17.680738 |          16.970884 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  0.856072 |           0.789065 |
| components...                  |           |                    |
| * Enabled addons:              |  0.004272 |           0.004081 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.063005 |           0.062902 |
| configured to use "minikube"   |           |                    |
|                                |  0.004851 |           0.003584 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-08-11T19:10:18Z

kvm2 Driver
Times for minikube: [62.870738947999996 60.917771605 62.12622946699999]
Average time for minikube: 61.97158000666667

Times for Minikube (PR 8969): [62.108225051 61.92423689300001 59.963464648999995]
Average time for Minikube (PR 8969): 61.331975531000005

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8969) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.2 on Debian   |  0.059042 |           0.059226 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020938 |           0.019585 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003104 |           0.002944 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 39.901220 |          39.649818 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 20.056201 |          19.996126 |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.331628 |           1.352694 |
| components...                  |           |                    |
| * Enabled addons:              |  0.521415 |           0.166844 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.074966 |           0.078310 |
| configured to use "minikube"   |           |                    |
|                                |  0.003066 |           0.006428 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [28.300199521000003 27.055155162000005 25.108907275]
Average time for minikube: 26.82142065266667

Times for Minikube (PR 8969): [27.941649217 27.587390251000002 26.762106916]
Average time for Minikube (PR 8969): 27.430382127999994

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8969) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.2 on Debian   |  0.075078 |           0.070596 |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.099815 |           0.099423 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.054927 |           0.056777 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    |  8.503521 |           8.272597 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 17.233759 |          18.051680 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  0.778444 |           0.804669 |
| components...                  |           |                    |
| * Enabled addons:              |  0.005819 |           0.006140 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.065753 |           0.064196 |
| configured to use "minikube"   |           |                    |
|                                |  0.004306 |           0.004305 |
+--------------------------------+-----------+--------------------+

cmd/minikube/cmd/start.go

medyagh · 2020-08-11T19:14:34Z

cmd/minikube/cmd/start.go

+
+func skipErrorIfForceEnabled(code int, message string, v out.V) {
+	if !viper.GetBool(force) {
+		exit.WithCodeT(code, message, v)


hint to the user if they really want this, they can use --force flag
similar to what we had before

To use this version anyway, use the `--force` flag

I don't think we should be encouraging people to just use the --force flag if something isn't meeting minimum requirements -- it makes sense for k8s versions because users may be using <1.13 which is a reasonable use case, but not for anything else

cmd/minikube/cmd/start.go

minikube-pr-bot · 2020-08-11T19:49:44Z

kvm2 Driver
Times for minikube: [61.358223798 60.30609558199999 61.015274023]
Average time for minikube: 60.89319780100001

Times for Minikube (PR 8969): [57.33730473399999 57.560922812 60.89858327799999]
Average time for Minikube (PR 8969): 58.59893694133333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8969) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.2 on Debian   |  0.060223 |           0.057751 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020019 |           0.020320 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.002881 |           0.007184 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 38.196479 |          35.289852 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 20.838521 |          21.376536 |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.267991 |           1.451984 |
| components...                  |           |                    |
| * Enabled addons:              |  0.425559 |           0.317320 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.075233 |           0.072719 |
| configured to use "minikube"   |           |                    |
|                                |  0.006291 |           0.005270 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [28.53896905 27.858947439999998 26.67406436]
Average time for minikube: 27.690660283333333

Times for Minikube (PR 8969): [26.211586856000004 27.026615234 26.865174270000004]
Average time for Minikube (PR 8969): 26.701125453333333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8969) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.2 on Debian   |  0.071414 |           0.076153 |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.098052 |           0.101226 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.055037 |           0.055966 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    |  8.402396 |           8.488543 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 18.086766 |          17.077085 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  0.865460 |           0.812780 |
| components...                  |           |                    |
| * Enabled addons:              |  0.037122 |           0.022998 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.070557 |           0.062581 |
| configured to use "minikube"   |           |                    |
|                                |  0.003857 |           0.003795 |
+--------------------------------+-----------+--------------------+

skip vaildations if --force is supplied

789dfca

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 11, 2020

priyawadhwa changed the title ~~skip vaildations if --force is supplied~~ skip validations if --force is supplied Aug 11, 2020

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 11, 2020

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 11, 2020

k8s-ci-robot requested review from prasadkatti and RA489 August 11, 2020 18:17

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2020

Priya Wadhwa added 2 commits August 11, 2020 14:22

include memory check

74309a8

Run download only test with docker daemon unavailable

6ff308d

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 11, 2020

improve error handling

a69b419

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 11, 2020

medyagh requested changes Aug 11, 2020

View reviewed changes

Priya Wadhwa added 2 commits August 11, 2020 15:38

change function name

506279c

suggest --force for k8s version

f122dee

medyagh approved these changes Aug 11, 2020

View reviewed changes

priyawadhwa merged commit 51110db into kubernetes:master Aug 11, 2020

priyawadhwa deleted the cpu-limit branch August 11, 2020 22:16

fmotrifork mentioned this pull request Aug 13, 2020

minikube 1.12.3 fishworks/fish-food#893

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

skip validations if --force is supplied #8969

skip validations if --force is supplied #8969

priyawadhwa commented Aug 11, 2020 •

edited

Loading

priyawadhwa commented Aug 11, 2020

k8s-ci-robot commented Aug 11, 2020

minikube-pr-bot commented Aug 11, 2020

minikube-pr-bot commented Aug 11, 2020

medyagh Aug 11, 2020

priyawadhwa Aug 11, 2020

minikube-pr-bot commented Aug 11, 2020

skip validations if --force is supplied #8969

skip validations if --force is supplied #8969

Conversation

priyawadhwa commented Aug 11, 2020 • edited Loading

priyawadhwa commented Aug 11, 2020

k8s-ci-robot commented Aug 11, 2020

minikube-pr-bot commented Aug 11, 2020

minikube-pr-bot commented Aug 11, 2020

medyagh Aug 11, 2020

Choose a reason for hiding this comment

priyawadhwa Aug 11, 2020

Choose a reason for hiding this comment

minikube-pr-bot commented Aug 11, 2020

priyawadhwa commented Aug 11, 2020 •

edited

Loading