Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade crio to 1.17.3 #8922

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Upgrade crio to 1.17.3 #8922

merged 1 commit into from
Sep 9, 2020

Conversation

afbjorklund
Copy link
Collaborator

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2020
@afbjorklund afbjorklund mentioned this pull request Aug 5, 2020
Closed
medyagh
medyagh reviewed Aug 10, 2020
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind pulling upstream so this PR gets tested with ISO test?
#8851

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Aug 12, 2020 •
edited
Loading

do you mind pulling upstream so this PR gets tested with ISO test?

The build worked, but the tests failed. Now what ?

How do I know that they passed with 1.17.1 before ?

"NumberOfTests": 200, "NumberOfFail": 4, "NumberOfPass": 187, "NumberOfSkip": 9, "FailedTests": [ "TestRunningBinaryUpgrade", "TestStoppedBinaryUpgrade", "TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP", "TestFunctional/parallel/TunnelCmd/serial/AccessDirect" ]

@medyagh
Copy link
Member

medyagh commented Aug 25, 2020

do you mind pulling upstream so this PR gets tested with ISO test?

The build worked, but the tests failed. Now what ?

How do I know that they passed with 1.17.1 before ?

"NumberOfTests": 200, "NumberOfFail": 4, "NumberOfPass": 187, "NumberOfSkip": 9, "FailedTests": [ "TestRunningBinaryUpgrade", "TestStoppedBinaryUpgrade", "TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP", "TestFunctional/parallel/TunnelCmd/serial/AccessDirect" ]

valid questions.

@afbjorklund
Copy link
Collaborator Author

There is a 1.17.4 out (and 1.18.3 and 1.19.0RC1, but those require an OS upgrade for the newer go version)

priyawadhwa
priyawadhwa approved these changes Sep 9, 2020
View reviewed changes
Copy link

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that the test failures are flakes and unrelated to the ISO change. I'm going to merge this, build the ISO and open a separate PR to test it @ HEAD.

@priyawadhwa priyawadhwa merged commit 6d37a35 into kubernetes:master Sep 9, 2020
@fmotrifork fmotrifork mentioned this pull request Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh left review comments

@priyawadhwa priyawadhwa priyawadhwa approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afbjorklund @k8s-ci-robot @medyagh @priyawadhwa