Upgrade storage provisioner image

[priyawadhwa]

This PR:

1. Upgrades the storage provisioner image to v2. It also makes it easier to upgrade in the future (all we need to do now is upgrade the version in the makefile & push the image)
2. Fixes a bug in the storage provisioner, where we were not applying the ClusterRoleBindings to the correct service account that the storage provisioner pod was running under
3. Beefs up the integration test to make sure files are actually persisted in PVs across pod deletion
4. Upgrades preload to v5 since the storage provisioner image is one of the images in the preload tarball

Fixes #8876

[priyawadhwa]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [priyawadhwa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[TravisBuddy]

Travis tests have failed

Hey @priyawadhwa,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.12.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.12.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="3f13b153960a2ca6706173eb830f1b49fc2a5f25" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v2" ./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.29.0'
golangci/golangci-lint info found version: 1.29.0 for v1.29.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
test/integration/fn_pvc_test.go:122:1: context.Context should be the first parameter of a function (golint)
func createPVTestPod(t *testing.T, ctx context.Context, profile string) {
^
Makefile:389: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= go mod ================================================================
ok
= boilerplate ===========================================================
ok
Makefile:273: recipe for target 'test' failed
make: *** [test] Error 4

TravisBuddy Request Identifier: cba7c410-d5c3-11ea-8ca9-c37e1b84d109

[minikube-pr-bot]

kvm2 Driver
docker Driver

[sharifelgamal]

As long as the new tests pass this LGTM

[medyagh]

looks good, if been tested with the built image.

[minikube-pr-bot]

kvm2 Driver
Times for minikube: [62.79886629 75.913854146 64.479947374]
Average time for minikube: 67.73088927

Times for Minikube (PR 8909): [109.42948627899997 105.358073521 100.335008648]
Average time for Minikube (PR 8909): 105.04085614933332

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8909) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.070933 |           0.069691 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020817 |           0.023725 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003195 |           0.039005 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 42.732042 |          20.172948 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 22.833547 |          82.435347 |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.503051 |           1.729410 |
| components...                  |           |                    |
| * Enabled addons:              |  0.488969 |           0.478613 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.071160 |           0.083618 |
| configured to use "minikube"   |           |                    |
|                                |  0.007176 |           0.008500 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [36.274557948 30.246446404000004 29.305365424]
Average time for minikube: 31.94212325866667

Times for Minikube (PR 8909): [53.261083398 54.80293129499999 53.596271932]
Average time for Minikube (PR 8909): 53.88676220833333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8909) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.093296 |           0.092601 |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.116000 |           0.115434 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.067397 |           0.111634 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    | 11.428755 |           6.250493 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 19.106447 |          46.244877 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.049705 |           0.994612 |
| components...                  |           |                    |
| * Enabled addons:              |  0.003037 |           0.002694 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.071881 |           0.065165 |
| configured to use "minikube"   |           |                    |
|                                |  0.005606 |           0.009254 |
+--------------------------------+-----------+--------------------+

[priyawadhwa]

Merging, as the TestDownloadOnly and TestStartStop failures are happening because v5 of preload hasn't been generated yet. I'll start a manual rebuild of preload tarballs after merge.