Fix handling of parseIP error #8820

Dean-Coakley · 2020-07-24T01:58:48Z

Before changes:

$ minikube ip delete
$ minikube start
...
🐳  Preparing Kubernetes v1.18.3 on Docker 19.03.8 ...

In a separate terminal session

$ minikube ip
<nil>
$ echo $?
0

Fix

(Same repro steps)

$ minikube ip

💣  Unable to get forwarded endpoint: failed to parse ip

😿  minikube is exiting due to an error. If the above message is not useful, open an issue:
👉  https://github.com/kubernetes/minikube/issues/new/choose
➜  minikube git:(fix-minikube-ip-errhandle) echo $?
70

k8s-ci-robot · 2020-07-24T01:58:56Z

Hi @Dean-Coakley. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-07-24T01:59:06Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Dean-Coakley
To complete the pull request process, please assign josedonizetti
You can assign the PR to them by writing /assign @josedonizetti in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pkg/minikube/driver/endpoint.go

minikube-bot · 2020-07-24T02:03:03Z

Can one of the admins verify this patch?

codecov-commenter · 2020-07-24T02:08:32Z

Codecov Report

Merging #8820 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #8820      +/-   ##
==========================================
- Coverage   32.06%   32.04%   -0.03%     
==========================================
  Files         161      165       +4     
  Lines       10533    10908     +375     
==========================================
+ Hits         3377     3495     +118     
- Misses       6752     6998     +246     
- Partials      404      415      +11

Impacted Files	Coverage Δ
pkg/minikube/driver/endpoint.go	`0.00% <0.00%> (ø)`
pkg/minikube/cruntime/crio.go	`29.34% <0.00%> (-16.89%)`	⬇️
pkg/minikube/out/out.go	`37.73% <0.00%> (-8.84%)`	⬇️
pkg/minikube/driver/driver.go	`52.50% <0.00%> (-7.50%)`	⬇️
pkg/minikube/localpath/localpath.go	`47.05% <0.00%> (-6.68%)`	⬇️
pkg/minikube/config/extra_options.go	`67.18% <0.00%> (-3.41%)`	⬇️
cmd/minikube/cmd/start_flags.go	`49.69% <0.00%> (-1.76%)`	⬇️
cmd/minikube/cmd/start.go	`11.16% <0.00%> (-1.76%)`	⬇️
pkg/minikube/cruntime/containerd.go	`27.27% <0.00%> (-1.73%)`	⬇️
pkg/minikube/machine/info.go	`27.50% <0.00%> (-0.71%)`	⬇️
... and 16 more

pkg/minikube/driver/endpoint.go

sharifelgamal · 2020-07-24T17:46:48Z

/ok-to-test

minikube-pr-bot · 2020-07-24T17:56:09Z

kvm2 Driver
docker Driver

pkg/minikube/driver/endpoint.go

TravisBuddy · 2020-07-24T20:17:51Z

Travis tests have failed

Hey @Dean-Coakley,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.12.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.12.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="ad31e7df882395193d9b033e864ac034858a3276"" ./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.26.0'
golangci/golangci-lint info found version: 1.26.0 for v1.26.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
ok
= go mod ================================================================
ok
= boilerplate ===========================================================
boilerplate missing: /home/travis/gopath/src/github.com/kubernetes/minikube/test/stress/stress.sh
consider running: /home/travis/gopath/src/github.com/kubernetes/minikube/hack/boilerplate/fix.sh
Makefile:274: recipe for target 'test' failed
make: *** [test] Error 8

TravisBuddy Request Identifier: be1574e0-cdea-11ea-98fb-f5dcae6af814

minikube-pr-bot · 2020-07-24T20:26:14Z

kvm2 Driver
Times for minikube: [62.585477729000004 62.19581000999999 61.181248639]
Average time for minikube: 61.98751212599999

Times for Minikube (PR 8820): [64.48017044800001 66.392330322 61.62921718199999]
Average time for Minikube (PR 8820): 64.16723931733334

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8820) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.060211 |           0.056768 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020627 |           0.020673 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.002974 |           0.003010 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.387229 |          40.894835 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 20.049196 |          21.672003 |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.380399 |           1.370640 |
| components...                  |           |                    |
| * Enabled addons:              |  0.009670 |           0.067992 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.073349 |           0.076475 |
| configured to use "minikube"   |           |                    |
|                                |  0.003856 |           0.004844 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.219613201999998 25.18121412 25.801364286000002]
Average time for minikube: 25.73406386933333

Times for Minikube (PR 8820): [25.971811587 27.825185428999998 26.310734416]
Average time for Minikube (PR 8820): 26.702577144

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8820) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.074418 |           0.073473 |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.100586 |           0.098234 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.056275 |           0.057009 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    |  8.386500 |           8.307987 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 16.148256 |          17.238559 |
| on Docker 19.03.2 ...          |           |                    |
| * Verifying Kubernetes         |  0.835832 |           0.838720 |
| components...                  |           |                    |
| * Enabled addons:              |  0.063946 |           0.021366 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.063582 |           0.062775 |
| configured to use "minikube"   |           |                    |
|                                |  0.004668 |           0.004455 |
+--------------------------------+-----------+--------------------+

Dean-Coakley · 2020-07-24T20:33:18Z

(Kept same commit structure, needed to rebase to fix lint test)

TravisBuddy · 2020-07-24T20:38:23Z

Travis tests have failed

Hey @Dean-Coakley,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.12.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.12.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="41bdc9bda61ddfff7dbf850c08ac977ee55ec0c4"" ./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.26.0'
golangci/golangci-lint info found version: 1.26.0 for v1.26.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
ok
= go mod ================================================================
ok
= boilerplate ===========================================================
boilerplate missing: /home/travis/gopath/src/github.com/kubernetes/minikube/test/stress/stress.sh
consider running: /home/travis/gopath/src/github.com/kubernetes/minikube/hack/boilerplate/fix.sh
Makefile:274: recipe for target 'test' failed
make: *** [test] Error 8

TravisBuddy Request Identifier: 9cd6d690-cded-11ea-98fb-f5dcae6af814

sharifelgamal · 2020-07-27T23:11:42Z

/ok-to-test

sharifelgamal · 2020-08-10T16:28:31Z

@Dean-Coakley can you rebase against master so we can retest? This change looks good and I'd like to merge it soon.

Dean-Coakley · 2020-08-11T00:08:03Z

/retest unit_test

k8s-ci-robot · 2020-08-11T00:08:17Z

@Dean-Coakley: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

/test pull-minikube-platform-tests

In response to this:

/retest unit_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Dean-Coakley · 2020-08-11T00:09:03Z

/test unit_test

k8s-ci-robot · 2020-08-11T00:09:17Z

@Dean-Coakley: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test pull-minikube-platform-tests

In response to this:

/test unit_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Dean-Coakley · 2020-08-11T12:32:43Z

/retest

medyagh · 2020-08-11T22:52:18Z

thank you @Dean-Coakley

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 24, 2020

k8s-ci-robot requested review from prasadkatti and sharifelgamal July 24, 2020 01:59

Dean-Coakley commented Jul 24, 2020

View reviewed changes

pkg/minikube/driver/endpoint.go Outdated Show resolved Hide resolved

medyagh requested changes Jul 24, 2020

View reviewed changes

pkg/minikube/driver/endpoint.go Outdated Show resolved Hide resolved

pkg/minikube/driver/endpoint.go Outdated Show resolved Hide resolved

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 24, 2020

medyagh reviewed Jul 24, 2020

View reviewed changes

pkg/minikube/driver/endpoint.go Outdated Show resolved Hide resolved

Dean-Coakley force-pushed the fix-minikube-ip-errhandle branch from 4b04b31 to 6958f49 Compare July 24, 2020 20:32

Dean-Coakley requested a review from medyagh July 31, 2020 02:36

Fix handling of parseIP error

c3de6d6

Dean-Coakley force-pushed the fix-minikube-ip-errhandle branch from 6958f49 to c3de6d6 Compare August 10, 2020 23:59

medyagh approved these changes Aug 11, 2020

View reviewed changes

medyagh merged commit f6ebaa8 into kubernetes:master Aug 11, 2020

Dean-Coakley deleted the fix-minikube-ip-errhandle branch August 12, 2020 09:01

fmotrifork mentioned this pull request Aug 13, 2020

minikube 1.12.3 fishworks/fish-food#893

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix handling of parseIP error #8820

Fix handling of parseIP error #8820

Dean-Coakley commented Jul 24, 2020

k8s-ci-robot commented Jul 24, 2020

k8s-ci-robot commented Jul 24, 2020

minikube-bot commented Jul 24, 2020

codecov-commenter commented Jul 24, 2020

sharifelgamal commented Jul 24, 2020

minikube-pr-bot commented Jul 24, 2020

TravisBuddy commented Jul 24, 2020

minikube-pr-bot commented Jul 24, 2020

Dean-Coakley commented Jul 24, 2020

TravisBuddy commented Jul 24, 2020

sharifelgamal commented Jul 27, 2020

sharifelgamal commented Aug 10, 2020

Dean-Coakley commented Aug 11, 2020

k8s-ci-robot commented Aug 11, 2020

Dean-Coakley commented Aug 11, 2020

k8s-ci-robot commented Aug 11, 2020

Dean-Coakley commented Aug 11, 2020

medyagh commented Aug 11, 2020

Fix handling of parseIP error #8820

Fix handling of parseIP error #8820

Conversation

Dean-Coakley commented Jul 24, 2020

Before changes:

Fix

k8s-ci-robot commented Jul 24, 2020

k8s-ci-robot commented Jul 24, 2020

minikube-bot commented Jul 24, 2020

codecov-commenter commented Jul 24, 2020

Codecov Report

sharifelgamal commented Jul 24, 2020

minikube-pr-bot commented Jul 24, 2020

TravisBuddy commented Jul 24, 2020

Travis tests have failed

1st Build

TravisBuddy Request Identifier: be1574e0-cdea-11ea-98fb-f5dcae6af814

minikube-pr-bot commented Jul 24, 2020

Dean-Coakley commented Jul 24, 2020

TravisBuddy commented Jul 24, 2020

Travis tests have failed

1st Build

TravisBuddy Request Identifier: 9cd6d690-cded-11ea-98fb-f5dcae6af814

sharifelgamal commented Jul 27, 2020

sharifelgamal commented Aug 10, 2020

Dean-Coakley commented Aug 11, 2020

k8s-ci-robot commented Aug 11, 2020

Dean-Coakley commented Aug 11, 2020

k8s-ci-robot commented Aug 11, 2020

Dean-Coakley commented Aug 11, 2020

medyagh commented Aug 11, 2020