Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Warning type for JSON output #8793

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Implement Warning type for JSON output #8793

merged 1 commit into from
Jul 21, 2020

Conversation

priyawadhwa
Copy link

Part of #8655

@priyawadhwa priyawadhwa changed the title Implement warning type for JSON output Implement Warning type for JSON output Jul 21, 2020
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2020
@priyawadhwa
Copy link
Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Jul 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
docker Driver

medyagh
medyagh approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, nit: could add example output json warrning in the PR description

@priyawadhwa priyawadhwa merged commit 6df5d19 into kubernetes:master Jul 21, 2020
@priyawadhwa priyawadhwa deleted the warning branch July 21, 2020 22:17
@fmotrifork fmotrifork mentioned this pull request Aug 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@priyawadhwa @k8s-ci-robot @minikube-pr-bot @medyagh