none CNI: error if portmap plug-in is required but unavailable #8684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/S
medyagh
requested changes
Jul 8, 2020
| } else { | ||
| rr, err = Run(t, exec.CommandContext(ctx, Target(), "ssh", "-p", profile, "pgrep -a kubelet")) | ||
| } | ||
|
|
||
| if err != nil { | ||
| t.Fatalf("ssh failed: %v", err) |
There was a problem hiding this comment.
update this message. since it is not SSH in none
medyagh
reviewed
Jul 8, 2020
medyagh
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flannelandkindnetboth require that theportmapCNI plug-in to be installed.Our VM and Docker image includes it, but it's presence cannot be assumed for the
nonedriver, resulting in a very confusing error message. This makes PR makes the omission very apparent.It also fixes an integration test assumption that did not work for
none, but does not endeavor to enable CNI tests fornoneyet.