upgrade: bump kube library version to latest 1.18.5 #8671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
Welcome @vinu2003! |
|
Hi @vinu2003. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vinu2003 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Travis tests have failedHey @vinu2003, 1st Buildmake testTravisBuddy Request Identifier: bca5e060-c0e6-11ea-9c30-6301f8ea01dd |
|
Can one of the admins verify this patch? |
|
I am noticing from the log, the issue is with Netlify build.command The problem seem to be in podman.md file : |
|
/assign afbjorklund |
|
Hey @afbjorklund Kindly let me know if i can go ahead and fix the Netlify build failure in this PR itself or as different one. |
|
I have created a PR to fix the build issues : #8678. |
medyagh
requested changes
Jul 8, 2020
vinu2003
force-pushed
the
bumpup-kubelib-version-18.5
branch
from
fba590a
to
a106636
Compare
medyagh
requested changes
Jul 10, 2020
vinu2003
force-pushed
the
bumpup-kubelib-version-18.5
branch
from
a106636
to
67911b7
Compare
|
/assign vinu2003 |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
kvm2 Driver Times for Minikube (PR 8671): [63.546365468999994 63.877615606999996 65.941453254] Averages Time Per Log docker Driver Times for Minikube (PR 8671): [24.556380758000003 25.50736819 26.07311083] Averages Time Per Log |
vinu2003
force-pushed
the
bumpup-kubelib-version-18.5
branch
from
67911b7
to
8fe9d42
Compare
|
I do notice some specific failures in many pull requests. Trying to see if i can help to fix any of these. |
vinu2003
force-pushed
the
bumpup-kubelib-version-18.5
branch
from
8fe9d42
to
8af9f92
Compare
vinu2003
force-pushed
the
bumpup-kubelib-version-18.5
branch
2 times, most recently
from
5f47418
to
e9c6dd0
Compare
|
kvm2 Driver Times for Minikube (PR 8671): [69.37045975400001 65.684959125 68.829346976] Averages Time Per Log docker Driver Times for Minikube (PR 8671): [27.628791540000005 29.109931954000004 27.878303416] Averages Time Per Log |
|
/retest |
|
@vinu2003: The specified target(s) for
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vinu2003: The specified target(s) for
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-minikube-platform-tests |
|
/retest |
|
@vinu2003: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
vinu2003
force-pushed
the
bumpup-kubelib-version-18.5
branch
from
e9c6dd0
to
df7ce6c
Compare
k8s-ci-robot
added
size/L
vinu2003
force-pushed
the
bumpup-kubelib-version-18.5
branch
from
df7ce6c
to
3fbd45b
Compare
medyagh
requested changes
Jul 25, 2020
| expectedKubeadmFeatureArgs: map[string]bool{ | ||
| "CoreDNS": true, | ||
| "IPv6DualStack": true, |
There was a problem hiding this comment.
I am not convinced these values are correct can you link in comment where the official site says the coredns is renamed to ipv6dualstack ?
There was a problem hiding this comment.
Hey @medyagh I came across this issue while running the tests. And was referring to release notes v1.18
https://kubernetes.io/docs/setup/release/notes/
kubeadm: remove the deprecated CoreDNS feature-gate. It was set to "true" since v1.11 when the feature went GA. In v1.13 it was marked as deprecated and hidden from the CLI. (#87400, @neolit123) [SIG Cluster Lifecycle]
Checked this PR - kubernetes/kubernetes#87400 - https://kubernetes.io/docs/reference/using-api/deprecation-policy/#deprecation.
I will see if I am missing to understand anything else from my end as well.
There was a problem hiding this comment.
@medyagh - CoreDNS is not renamed to IPv6DualStack.
In Kubeadm, CoreDNS feature gate is deprecated and removed. This particular test in minikube-bsutil is related to feature gates. So it makes sense to replace with IPv6DualStack.
https://kubernetes.io/docs/setup/release/notes/
There was a problem hiding this comment.
so that would make a problem if a user wants to deploy an older kubernetes version to minikube ?
There was a problem hiding this comment.
Hi @medyagh Apologies for delayed responses - i was away for a while.
It is indeed not backward compatible if, the user starts cluster with feature gates option --feature-gates CoreDNS=true with this dependency upgrade as the kubeadm refers to v1.18.5
But I was able to start the cluster successfully with older version of kubernetes with this change.
./out/minikube start --kubernetes-version v1.17.0
Haven't tried something like supporting multiple versions in go mod.Not sure if that is an optimal solution to this as I still exploring the architecture and learning.
Also, I noticed that i should be bumping to 1.18.3 and not 1.18.5.
DefaultKubernetesVersion = "v1.18.3". - This is seperate.
There was a problem hiding this comment.
Hey @medyagh as far as i have analysed into this, adding k8s as module means adding the subcomponents under require directive and this specific feature gates is part of kubeadm and there is no way to support different versions of it.
i have also looking into this PR earlier when its bumped up to 1.15
#4719 - which eventually replaced the older feature gates and added CoreDNS part.
Provided this CoreDNS is depreciated, can we go for another Pr with v18.3 which will have the same impact of backward compatibility when the driver is started that eventually calls kubeadm init feature-gates=CoreDNS.
But the user can start the old driver without this option.
Not sure how to move forward with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##what/why this PR##:
This PR addresses changes required in go.mod/go.sum files to update kube library version from v1.17.3 to v1.18.5.
##Which issue this PR fixes##:
fixes: #8656