Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go version to 1.14.4 #8660

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Upgrade go version to 1.14.4 #8660

merged 1 commit into from
Jul 10, 2020

Conversation

RA489
Copy link

@RA489 RA489 commented Jul 7, 2020

Upgrade go version to 1.14.4

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 7, 2020
@RA489
Copy link
Author

RA489 commented Jul 7, 2020

/assign @medyagh

afbjorklund
afbjorklund requested changes Jul 7, 2020
View reviewed changes
Copy link
Collaborator

@afbjorklund afbjorklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the kube-cross image was missing

Makefile Show resolved Hide resolved
@tstromberg
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 7, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
docker Driver

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RA489
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

medyagh
medyagh approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@medyagh medyagh merged commit 5df15f6 into kubernetes:master Jul 10, 2020
@fmotrifork fmotrifork mentioned this pull request Aug 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund afbjorklund approved these changes

@medyagh medyagh medyagh approved these changes

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees

@medyagh medyagh

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RA489 @tstromberg @minikube-pr-bot @k8s-ci-robot @medyagh @afbjorklund