Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ebpf documentation #8607

Closed
wants to merge 1 commit into from

Conversation

alban
Copy link
Contributor

@alban alban commented Jun 30, 2020

Following #8582, the documentation about ebpf tools should be updated:
https://minikube.sigs.k8s.io/docs/tutorials/ebpf_tools_in_minikube/

I am also adding an example with Inspektor Gadget.

TODO:

  • Get the proper URL for minikube.iso. According to @afbjorklund, there is some CI issues to generate a new one.
  • We need a new release of Inspektor Gadget first, and the doc should say which version is required.
  • Specify which release of minikube is required for this?

/cc @mauriciovasquezbernal @marga-kinvolk

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2020
@k8s-ci-robot
Copy link
Contributor

@alban: GitHub didn't allow me to request PR reviews from the following users: mauriciovasquezbernal, marga-kinvolk.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Following #8582, the documentation about ebpf tools should be updated:
https://minikube.sigs.k8s.io/docs/tutorials/ebpf_tools_in_minikube/

I am also adding an example with Inspektor Gadget.

TODO:

  • Get the proper URL for minikube.iso. According to @afbjorklund, there is some CI issues to generate a new one.
  • We need a new release of Inspektor Gadget first, and the doc should say which version is required.
  • Specify which release of minikube is required for this?

/cc @mauriciovasquezbernal @marga-kinvolk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 30, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @alban. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alban
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@afbjorklund
Copy link
Collaborator

afbjorklund commented Jun 30, 2020

* According to @afbjorklund, there is some CI issues to generate a new one.

Not so much with generation, we had some issues during testing it though...

See #8466

So there is a new beta version available, that can be used for manual testing.

See #8558

@sharifelgamal
Copy link
Collaborator

Is this still in progress?

@alban
Copy link
Contributor Author

alban commented Jul 29, 2020

I didn't have time to work more on this.

It is currently blocked by the revert of the kernel option, see:
#8556 (comment)

And ideally, I'd like to have this other kernel option too:
#8637

@medyagh
Copy link
Member

medyagh commented Sep 23, 2020

@alban are you still working on this PR ?

@alban
Copy link
Contributor Author

alban commented Sep 23, 2020

I am not. Feel free to close this PR for now. It can be reopened later after the two other issues mentioned above are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants