Generate cri-o container runtime preload tarball #8581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #8581 +/- ##
==========================================
- Coverage 32.14% 32.05% -0.09%
==========================================
Files 161 161
Lines 10494 10523 +29
==========================================
Hits 3373 3373
- Misses 6717 6746 +29
Partials 404 404
|
medyagh
reviewed
Jun 27, 2020
|
It seems to auto-upload, so I guess I need to comment that out... And need to determine if that “cache” folder is required by the “storage” So maybe need the preload part as well, to see whether it actually works ? |
afbjorklund
force-pushed
the
preload-crio
branch
from
fdbab9f
to
1bf268c
Compare
|
I included everything for now, until I actually know what is in those databases... Note that the "sigstore" and "mounts" are empty, so it's just about "cache". Seems to have worked otherwise. Tested with just the default k8s version. Note: that this Step 1 was only about creating the tarball, not about using it |
|
The name "overlay2" seems to be hard-coded. It was supposed to be "overlay"... // TarballName returns name of the tarball
func TarballName(k8sVersion, containerRuntime string) string {
return fmt.Sprintf("preloaded-images-k8s-%s-%s-%s-overlay2-%s.tar.lz4", PreloadVersion, k8sVersion, containerRuntime, runtime.GOARCH)
}
Fixed the name from the start. The actual API is a bit stupid (uses strings), so still hard-coded. if containerRuntime == "cri-o" {
storageDriver = "overlay"
} else {
storageDriver = "overlay2"
} |
afbjorklund
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
size/M
afbjorklund
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
New name: |
|
@medyagh : trying to use preload with podman currently fails with the usual problem of overloading So we should fix that one (#8056 #8100 #8179) first, before enabling this feature. But we need these tarballs, first. EDIT: This is only a problem for the KIC drivers, we can still use preloaded tarballs with the VM drivers |
Pretty much the same as containerd, minus Restart (cherry picked from commit d9fb2e0)
medyagh
requested changes
Jun 30, 2020
medyagh
requested changes
Jun 30, 2020
k8s-ci-robot
added
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Tested locally, seems to work ok: |
Travis tests have failedHey @afbjorklund, 1st Buildmake testTravisBuddy Request Identifier: a9c15360-baf3-11ea-bd85-f15c2d376ac7 |
medyagh
requested changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cri-o, to the list of preloaded tarballs:
For #6934