-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Cilium CNI (--cni=cilium) #8573
Conversation
/ok-to-test |
kvm2 Driver |
Please check this error Docker Driver: TestNetworkPlugins/group/kindnet/DNS
Virtualbox TestNetworkPlugins/group/kindnet/DNS
Virtualbox: TestNetworkPlugins/group/custom-weave/DNS
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make sure the integretion test pass consistantly or adjust the test to make for for the knwon limitations/flakes if there is... so we dont get used to see red failures
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Travis tests have failedHey @tstromberg, 1st Buildmake test
TravisBuddy Request Identifier: 5b082900-c71a-11ea-aa06-e17841301e13 |
kvm2 Driver Times for Minikube (PR 8573): [60.787252577000004 61.778035454999994 64.966267632] Averages Time Per Log
docker Driver Times for Minikube (PR 8573): [26.181003405000002 26.177749961999996 32.819179585] Averages Time Per Log
|
@tstromberg thank you for adding support for Cilium in minkube. would you mind adding minikube to the Cilium adopters list? https://github.com/cilium/cilium/blob/master/USERS.md We need this for when we apply to graduate at the CNCF |
No description provided.