-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add verification for enabling ingress, registry and gvisor addons #8563
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Travis tests have failedHey @medyagh, 1st Buildmake test
TravisBuddy Request Identifier: ef9df3b0-b734-11ea-90cf-99978df78ba0 |
Travis tests have failedHey @medyagh, 1st Buildmake test
TravisBuddy Request Identifier: 129473d0-b735-11ea-90cf-99978df78ba0 |
Travis tests have failedHey @medyagh, 1st Buildmake test
2nd Buildmake test
TravisBuddy Request Identifier: b247a190-b735-11ea-90cf-99978df78ba0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
After this PR:
Added the Pod Label Verification for 3 popular addon
will wait for the addon pod to be running, before exiting, this will eleminate a lot of integration test and docs needing waiting for pod to be running
as seen in kuberentes docs https://kubernetes.io/docs/tasks/access-application-cluster/ingress-minikube/