Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce coredns replicas from 2 to 1 #8552

Merged
merged 3 commits into from
Jun 25, 2020
Merged

Reduce coredns replicas from 2 to 1 #8552

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d3a0c4
Reduce coredns replicas from 2 to 1
Jun 25, 2020
1b8eaaf
Move kubectl binary function to kapi package to prevent future cyclic…
Jun 25, 2020
1769750
fix log level
Jun 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/addons/kubectl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func kubectlCommand(cc *config.ClusterConfig, files []string, enable bool) *exec
v = cc.KubernetesConfig.KubernetesVersion
}

kubectlBinary := kubectlBinaryPath(v)
kubectlBinary := KubectlBinaryPath(v)

kubectlAction := "apply"
if !enable {
Expand All @@ -47,6 +47,7 @@ func kubectlCommand(cc *config.ClusterConfig, files []string, enable bool) *exec
return exec.Command("sudo", args...)
}

func kubectlBinaryPath(version string) string {
// KubectlBinaryPath returns the path to kubectl on the node
func KubectlBinaryPath(version string) string {
priyawadhwa marked this conversation as resolved.
Show resolved Hide resolved
return path.Join(vmpath.GuestPersistentDir, "binaries", version, "kubectl")
}
18 changes: 18 additions & 0 deletions pkg/minikube/node/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,12 @@ func Start(starter Starter, apiServer bool) (*kubeconfig.Settings, error) {
go addons.Start(&wg, starter.Cfg, starter.ExistingAddons, config.AddonList)
}

wg.Add(1)
go func() {
rescaleCoreDNS(starter.Cfg, starter.Runner)
wg.Done()
}()

if apiServer {
// special ops for none , like change minikube directory.
// multinode super doesn't work on the none driver
Expand Down Expand Up @@ -507,3 +513,15 @@ func prepareNone() {
exit.WithCodeT(exit.Permissions, "Failed to change permissions for {{.minikube_dir_path}}: {{.error}}", out.V{"minikube_dir_path": localpath.MiniPath(), "error": err})
}
}

// rescaleCoreDNS attempts to reduce coredns replicas from 2 to 1 to improve CPU overhead
// no worries if this doesn't work
func rescaleCoreDNS(cc *config.ClusterConfig, runner command.Runner) {
kubectl := addons.KubectlBinaryPath(cc.KubernetesConfig.KubernetesVersion)
cmd := exec.Command("sudo", "KUBECONFIG=/var/lib/minikube/kubeconfig", kubectl, "scale", "deployment", "--replicas=1", "coredns", "-n=kube-system")
if _, err := runner.RunCmd(cmd); err != nil {
glog.Infof("unable to scale coredns replicas to 1: %v", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be warningf

} else {
glog.Infof("successfully scaled coredns replicas to 1")
}
}