Adds support for unsetting of env vars

[Harkishen-Singh]

Signed-off-by: Harkishen-Singh [email protected]

Fixes: #8476

Behaviour before this PR

[hsingh@localhost out]$ ./minikube docker-env --unset
🤷  The control plane node must be running for this command
👉  To fix this, run: "minikube start"

Behaviour after this PR

[hsingh@localhost out]$ ./minikube docker-env --unset
unset DOCKER_TLS_VERIFY DOCKER_HOST DOCKER_CERT_PATH MINIKUBE_ACTIVE_DOCKERD

Reference: #8476 (comment)

Explanation:
The unsettling of env-vars in docker should be independent of whether the docker-machine is running or not. This is minikube specific issue and was occurring due co := mustload.Running(cname). Moving the unset statements up, before the running-checks solves the issue. Similar is the situation for podman.

[k8s-ci-robot]

Welcome @Harkishen-Singh!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Harkishen-Singh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Harkishen-Singh
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[Harkishen-Singh]

In reference to #8476 (comment)

[Harkishen-Singh]

/assign @medyagh

[medyagh]

@Harkishen-Singh thank you for this PR, do you mind putting in the PR description the Before and After this PR's output and explain how it is fixing the issue?

[Harkishen-Singh]

@medyagh sure.

[Harkishen-Singh]

@medyagh Done!

[medyagh]

@Harkishen-Singh Thank you very much for this helpful PR ! I hope I get to see more contributions from you

[Harkishen-Singh]

@medyagh definitely! Thank you.

[medyagh]

@Harkishen-Singh please feel free to take issues labeled help-wanted or good-first-issue
https://github.com/kubernetes/minikube/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22

[Harkishen-Singh]

@medyagh sure.