Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the type referenced for PortRange. #847

Merged
merged 1 commit into from
Nov 23, 2016
Merged

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Nov 23, 2016

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 23, 2016
@dlorenc
Copy link
Contributor Author

dlorenc commented Nov 23, 2016

Fixes #836

@codecov-io
Copy link

Current coverage is 33.19% (diff: 0.00%)

Merging #847 into master will not change coverage

@@             master       #847   diff @@
==========================================
  Files            43         43          
  Lines          1895       1895          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            629        629          
  Misses         1146       1146          
  Partials        120        120          

Powered by Codecov. Last update 06f380a...bd0acdf

@dlorenc
Copy link
Contributor Author

dlorenc commented Nov 23, 2016

cc @dani8art you should be able to test this at:

https://storage.googleapis.com/minikube-builds/847/minikube-linux-amd64

Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this was my bad. This is actually being reflected back into the kube config so it can't use the client-go library.

@dlorenc dlorenc merged commit 611b8ae into kubernetes:master Nov 23, 2016
@dlorenc dlorenc deleted the type branch November 23, 2016 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants