docker driver: add fall back image in docker hub #8320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
medyagh
changed the title
priyawadhwa
reviewed
May 29, 2020
| // github packages docker does _NOT_ support pulling by sha as mentioned in the docs: | ||
| // https://help.github.com/en/packages/using-github-packages-with-your-projects-ecosystem/configuring-docker-for-use-with-github-packages | ||
| BaseImageFallBack = fmt.Sprintf("docker.pkg.github.com/kubernetes/minikube/kicbase:%s", Version) | ||
| BaseImageFallBack2 = fmt.Sprintf("docker.pkg.github.com/kubernetes/minikube/kicbase:%s", Version) |
There was a problem hiding this comment.
I think it would be cleaner to create an array of images, and then go through them in order until we find one that works
var BaseImages = []string{
fmt.Sprintf("gcr.io/k8s-minikube/kicbase:%s@sha256:%s", Version, baseImageSHA),
fmt.Sprintf("kicbase/stable:%s@sha256:%s", Version, baseImageSHA),
fmt.Sprintf("docker.pkg.github.com/kubernetes/minikube/kicbase:%s", Version)
}There was a problem hiding this comment.
sounds good the problem is when looping over the array, would need to detect if there is not any more fallback to return the error, seems like a good idea for a follow up refactor
There was a problem hiding this comment.
I agree, this should definitely be a slice.
Travis tests have failedHey @medyagh, 1st Buildmake testTravisBuddy Request Identifier: cf339fa0-a1de-11ea-b485-534d9f3e4954 |
Codecov Report
@@ Coverage Diff @@
## master #8320 +/- ##
=======================================
Coverage 34.37% 34.37%
=======================================
Files 147 147
Lines 9469 9469
=======================================
Hits 3255 3255
Misses 5814 5814
Partials 400 400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.