-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Dashboard to v2.0.1 #8294
Bump Dashboard to v2.0.1 #8294
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maciaszczykm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #8294 +/- ##
==========================================
- Coverage 34.37% 34.05% -0.33%
==========================================
Files 147 153 +6
Lines 9469 9840 +371
==========================================
+ Hits 3255 3351 +96
- Misses 5814 6086 +272
- Partials 400 403 +3
|
/ok-to-test |
kvm2 Driver |
Can you update the |
@sharifelgamal Sure, done. |
Travis tests have failedHey @maciaszczykm, 1st Buildmake test
TravisBuddy Request Identifier: edb3a350-a632-11ea-9311-0306711df575 |
kvm2 Driver Times for Minikube (PR 8294): [64.87011946400001 64.62282872600001 64.512497384] Averages Time Per Log
docker Driver Times for Minikube (PR 8294): [25.628722742 28.455538010999998 27.202515056] Averages Time Per Log
|
kvm2 Driver Times for Minikube (PR 8294): [83.12795324200002 85.28707665599998 82.219410953] Averages Time Per Log
docker Driver Times for Minikube (PR 8294): [43.24143647099999 45.2382496 44.449677711] Averages Time Per Log
|
Travis tests have failedHey @maciaszczykm, 1st Buildmake test
TravisBuddy Request Identifier: 98028b10-a641-11ea-9311-0306711df575 |
@maciaszczykm the unit tests are failing, you can run the unit test locally by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uni tests needs to be fixed
I hope this will fix the tests. |
kvm2 Driver Times for Minikube (PR 8294): [84.486549771 82.761693593 82.106060362] Averages Time Per Log
docker Driver Times for Minikube (PR 8294): [44.045857501 42.577733678 43.867012616] Averages Time Per Log
|
I am not sure what fails atm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is bumping two things at same time, I prefer to see them in separate PRs and also plz check the integration test failures
It is bumping two things that are coupled. Scraper is a tool that is created to be used by Dashboard and I think both of them should be updated together in the current situation. Since I am not sure what is failing you can change this pull request if you want or create two separate ones with changes that I did. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @maciaszczykm thanks for opening this PR. Could you please bump the preload version to v4
? You can reference https://github.com/kubernetes/minikube/pull/7849/files as well
@priyawadhwa Yes, thank you for the tip! |
kvm2 Driver Times for Minikube (PR 8294): [106.81876993 98.05036476600002 98.623432326] Averages Time Per Log
docker Driver Times for Minikube (PR 8294): [51.228049143 47.648061651999996 51.029957874999994] Averages Time Per Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for submitting this upgrade!
Thank you too :) |
No description provided.