Add HostIP implementation for parallels driver #8259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parallels Desktop works only on macOS (Darwin)
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
cncf-cla: no
|
Welcome @legal90! |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @legal90. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: legal90 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
|
Can one of the admins verify this patch? |
Travis tests have failedHey @legal90, 1st Buildmake test2nd Buildmake test3rd BuildmakeTravisBuddy Request Identifier: 0b6d30f0-9d19-11ea-8472-279b0b07e116 |
k8s-ci-robot
added
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #8259 +/- ##
==========================================
- Coverage 34.46% 34.40% -0.06%
==========================================
Files 147 147
Lines 9428 9444 +16
==========================================
Hits 3249 3249
- Misses 5780 5796 +16
Partials 399 399
|
|
It seems that these CI check failures are not related to this PR
|
medyagh
requested changes
May 23, 2020
Rename "cmd*" var to "bin*" in the parallels-specific block
|
Thank you, @medyagh! I added the output before/after this PR to the top message and also renamed the variable, as you asked. |
medyagh
approved these changes
May 24, 2020
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
kvm2 Driver Times for Minikube (PR 8259): [64.501283271 62.56648873 62.328824960000006] Averages Time Per Log docker Driver Times for Minikube (PR 8259): [27.714082698000002 27.046909114999995 27.339831469] Averages Time Per Log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Parallels/docker-machine-parallels#90
Fixes #4862
This PR does the following:
HostIPfunction, which actually fixes the entire compatibility of minikube with this driver.Tested on macOS 10.15.4 with
docker-machine-driver-parallelsv1.4.0 and Parallels Desktop for Mac 15.1.4.Before this PR
After this PR
Implementation details
Just for the reviewer's information:
The function is supposed to run the command
prlsrvctl net info Shared. Here is the full output example:Here we just parse this output to get the value of
IPv4 addressfield, which is10.211.55.2. The VM created by parallels driver is connected to the same virtual network and can access the host using this IP.