Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow minikube status to display for one node #8238

Merged
merged 6 commits into from
May 21, 2020

Conversation

sharifelgamal
Copy link
Collaborator

@sharifelgamal sharifelgamal commented May 21, 2020

For a non-standard status format in a multinode cluster, we were concatenating the results for all the nodes in a way that was impossible to digest. Now we default to only showing the status of the control plane for any non-standard status format.
For example, in a 3 node cluster:
Before:

minikube status --format {{.Host}}
RunningRunningRunning

After:

minikube status --format {{.Host}}
Running

You can also explicitly specify a node to check:

minikube status --format {{.Host}} --node m02
Running

minikube status --node m02
minikube-m02
type: Worker
host: Running
kubelet: Running

The standard format works like before:

minikube status
minikube
type: Control Plane
host: Running
kubelet: Running
apiserver: Running
kubeconfig: Configured

minikube-m02
type: Worker
host: Running
kubelet: Running

minikube-m03
type: Worker
host: Running
kubelet: Running

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2020
@kubernetes kubernetes deleted a comment from TravisBuddy May 21, 2020
@medyagh
Copy link
Member

medyagh commented May 21, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 21, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
docker Driver

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [66.998330258 64.34758321700001 62.80530103099999]
Average time for minikube: 64.717071502

Times for Minikube (PR 8238): [64.089207605 62.96519568000001 60.88969604099999]
Average time for Minikube (PR 8238): 62.648033108666674

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8238) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.059019 |           0.058756 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020090 |           0.021433 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003111 |           0.003127 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.134854 |          38.758810 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 21.815695 |          21.404054 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.349879 |           1.316889 |
| components...                  |           |                    |
| * Enabled addons:              |  0.258754 |           0.998230 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.072973 |           0.081975 |
| configured to use "minikube"   |           |                    |
|                                |  0.002696 |           0.004759 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.306738238999998 26.204489027999998 26.862606770000006]
Average time for minikube: 26.791278012333333

Times for Minikube (PR 8238): [25.830401988000002 27.750777286 26.500150622]
Average time for Minikube (PR 8238): 26.693776632

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8238) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.071169 |           0.068359 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002635 |           0.002733 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.059537 |           0.059083 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.787103 |           7.570452 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.116070 |           0.117165 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.821675 |          17.763396 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.861725 |           1.044412 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.002742 |           0.002519 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.064878 |           0.062270 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003743 |           0.003386 |
+----------------------------------------+-----------+--------------------+

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 21, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [64.803844119 68.28938041 63.331029786]
Average time for minikube: 65.47475143833333

Times for Minikube (PR 8238): [63.27453714600001 64.63990455700001 63.795858537]
Average time for Minikube (PR 8238): 63.903433413333325

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8238) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.061602 |           0.059521 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020114 |           0.021788 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003463 |           0.003264 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.516453 |          40.168248 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 22.771971 |          21.617265 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.518494 |           1.271032 |
| components...                  |           |                    |
| * Enabled addons:              |  0.491787 |           0.677067 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.087084 |           0.081368 |
| configured to use "minikube"   |           |                    |
|                                |  0.003784 |           0.003879 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.015474264999998 25.611595513999998 25.598178234000002]
Average time for minikube: 26.075082671

Times for Minikube (PR 8238): [26.486052773999997 26.979399301 27.232815487]
Average time for Minikube (PR 8238): 26.899422520666665

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8238) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.074788 |           0.074918 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002959 |           0.002483 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.058268 |           0.058633 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.738406 |           7.624213 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.118152 |           0.119939 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 16.785658 |          17.732441 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.203051 |           1.120840 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.020968 |           0.093276 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.070090 |           0.066712 |
| configured to use "minikube"           |           |                    |
|                                        |  0.002744 |           0.005969 |
+----------------------------------------+-----------+--------------------+

@medyagh medyagh merged commit f26ea0f into kubernetes:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants