-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid image builders to hang on registry port 443 #8208
Conversation
Welcome @nicolaferraro! |
Hi @nicolaferraro. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nicolaferraro The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #8208 +/- ##
==========================================
- Coverage 34.60% 34.59% -0.02%
==========================================
Files 147 147
Lines 9378 9381 +3
==========================================
Hits 3245 3245
- Misses 5736 5739 +3
Partials 397 397
|
thank you for fixing this, do u mind sharing the output that this fixes it ? |
This adds a mapping for the 443 port on the registry, because image publishers, in case of insecure registries, first try to contact port 443, then fallback on port 80.
But if port 443 is not mapped to the container (even on a closed port of the container, as in this case), then the application remains stuck until a timeout occurs. This in the end leads to really slow times for publishing an image.
This is happening e.g. in GoogleContainerTools/kaniko#1013