Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid image builders to hang on registry port 443 #8208

Merged
merged 1 commit into from
May 19, 2020

Conversation

nicolaferraro
Copy link
Contributor

This adds a mapping for the 443 port on the registry, because image publishers, in case of insecure registries, first try to contact port 443, then fallback on port 80.

But if port 443 is not mapped to the container (even on a closed port of the container, as in this case), then the application remains stuck until a timeout occurs. This in the end leads to really slow times for publishing an image.

This is happening e.g. in GoogleContainerTools/kaniko#1013

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 19, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @nicolaferraro!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 19, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @nicolaferraro. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nicolaferraro
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-commenter
Copy link

Codecov Report

Merging #8208 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8208      +/-   ##
==========================================
- Coverage   34.60%   34.59%   -0.02%     
==========================================
  Files         147      147              
  Lines        9378     9381       +3     
==========================================
  Hits         3245     3245              
- Misses       5736     5739       +3     
  Partials      397      397              
Impacted Files Coverage Δ
cmd/minikube/cmd/node_start.go 9.37% <0.00%> (-0.63%) ⬇️
cmd/minikube/cmd/node_stop.go 13.33% <0.00%> (-0.96%) ⬇️

@medyagh
Copy link
Member

medyagh commented May 19, 2020

thank you for fixing this, do u mind sharing the output that this fixes it ?

@medyagh medyagh merged commit ccb47f5 into kubernetes:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants