Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for kubernetes components on soft start #8199

Merged
merged 4 commits into from
May 19, 2020

Commits on May 18, 2020

  1. Add --wait=all flag to soft start

    Priya Wadhwa committed May 18, 2020
    Configuration menu
    Copy the full SHA
    bf8c4e3 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2020

  1. Move status command to TestFunctional/serial

    I noticed that TestComponentHealth/parallel/ComponentHealth was failing with this error:
    
    ```
    Error apiserver status: https://172.17.0.3:8441/healthz returned error 500:
    [-]etcd failed: reason withheld
    ```
    
    but by the time post mortem logs were printed the etcd container was up and running.
    
    I think this test occasionally fails because apiserver healthz is not yet returning a 200 status when we run the test. We wait for healthz to return 200 on regular start, but not on soft start, which we run in `TestFunctional`.
    
    This PR adds a retry, which should give the apiserver time to become healthy.
    Priya Wadhwa committed May 19, 2020
    Configuration menu
    Copy the full SHA
    cc40795 View commit details
    Browse the repository at this point in the history
  2. remove comments

    Priya Wadhwa committed May 19, 2020
    Configuration menu
    Copy the full SHA
    755c924 View commit details
    Browse the repository at this point in the history
  3. Respect --wait flag on soft start

    Priya Wadhwa committed May 19, 2020
    Configuration menu
    Copy the full SHA
    64e44ec View commit details
    Browse the repository at this point in the history