Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump helm-tiller 2.16.7 and promote tiller ClusterRoleBinding to v1 #8174

Merged
merged 1 commit into from
May 18, 2020
Merged

Bump helm-tiller 2.16.7 and promote tiller ClusterRoleBinding to v1 #8174

merged 1 commit into from
May 18, 2020

Conversation

govargo
Copy link
Contributor

@govargo govargo commented May 16, 2020

What type of PR is this?

/area addons

What this PR does / why we need it:

This is small PR.
This bump up helm-tiller addon's image v2.16.3 to v2.16.7 and promote ClusterRoleBinding to v1.

Which issue(s) this PR fixes:

Fixes #8173

Does this PR introduce a user-facing change?

Yes.
This image bumpup includes some helm2 bug fixes.
https://github.com/helm/helm/releases/tag/v2.16.7

Before

image: gcr.io/kubernetes-helm/tiller:v2.16.3

After

image: gcr.io/kubernetes-helm/tiller:v2.16.7

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @govargo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 16, 2020
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: govargo
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@govargo
Copy link
Contributor Author

govargo commented May 16, 2020

/assign @tstromberg

@codecov-io
Copy link

Codecov Report

Merging #8174 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8174   +/-   ##
=======================================
  Coverage   35.27%   35.27%           
=======================================
  Files         146      146           
  Lines        9327     9327           
=======================================
  Hits         3290     3290           
  Misses       5638     5638           
  Partials      399      399           

@medyagh
Copy link
Member

medyagh commented May 18, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 18, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
docker Driver

@medyagh medyagh merged commit c1e108e into kubernetes:master May 18, 2020
@govargo govargo deleted the bump-helm-2.16.7 branch February 13, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump helm-tiller 2.16.7
7 participants