Upgrade oldest k8s version supported to 1.13 #8154

priyawadhwa · 2020-05-14T21:05:46Z

Our old-k8s-version test has consistently been failing in CI (#8048) when testing k8s version 1.12

Unfortunately, I was unable to repro this bug locally, and the test consistently passed on my machine. It seems that for whatever reason, 1.13 passes on CI, so for now the current solution is to upgrade oldest k8s version to 1.13 so that we have reliable integration tests.

Users can still specify using k8s version 1.12 by running

minikube start --kubernetes-version v1.12.0 --force

closes #8048

k8s-ci-robot · 2020-05-14T21:06:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [priyawadhwa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

priyawadhwa · 2020-05-14T22:35:33Z

/ok-to-test

minikube-pr-bot · 2020-05-14T22:38:03Z

kvm2 Driver
docker Driver

minikube-pr-bot · 2020-05-15T18:47:02Z

kvm2 Driver
Times for minikube: [65.69503173300001 66.57408142199999 69.68276342799999]
Average time for minikube: 67.31729219433333

Times for Minikube (PR 8154): [64.66103687 66.04992261499999 65.41625457599999]
Average time for Minikube (PR 8154): 65.37573802033332

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8154) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.073327 |           0.066083 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.023429 |           0.023018 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003639 |           0.004022 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.852473 |          40.132655 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 23.936170 |          23.025877 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.500211 |           1.670191 |
| components...                  |           |                    |
| * Enabled addons:              |  0.823524 |           0.375285 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.098961 |           0.074663 |
| configured to use "minikube"   |           |                    |
|                                |  0.005560 |           0.003943 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [29.247568095000005 28.526829417000002 29.486404608]
Average time for minikube: 29.086934040000003

Times for Minikube (PR 8154): [29.078301047 28.031170774 28.320757192000002]
Average time for Minikube (PR 8154): 28.476743004333333

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8154) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.080805 |           0.080820 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002782 |           0.003228 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.062398 |           0.062776 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  8.024346 |           8.263478 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.131744 |           0.128217 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 19.482509 |          18.812254 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.227102 |           0.994864 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.003075 |           0.036886 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.068536 |           0.089870 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003636 |           0.004350 |
+----------------------------------------+-----------+--------------------+

codecov-io · 2020-05-15T19:56:12Z

Codecov Report

Merging #8154 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8154      +/-   ##
==========================================
- Coverage   35.27%   35.27%   -0.01%     
==========================================
  Files         146      146              
  Lines        9326     9327       +1     
==========================================
  Hits         3290     3290              
- Misses       5637     5638       +1     
  Partials      399      399

Impacted Files	Coverage Δ
cmd/minikube/cmd/start_flags.go	`50.80% <0.00%> (-0.17%)`	⬇️

minikube-pr-bot · 2020-05-15T20:06:29Z

kvm2 Driver
docker Driver
Times for minikube: [31.433282888999997 26.718299717000004 29.59893616]
Average time for minikube: 29.250172922

Times for Minikube (PR 8154): [28.521131311000005 27.843907519000005 28.066573526999996]
Average time for Minikube (PR 8154): 28.143870785666667

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8154) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.082979 |           0.082253 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002954 |           0.002898 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.063686 |           0.066858 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  8.571057 |           8.335297 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.131190 |           0.135047 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 19.389728 |          18.160913 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.930704 |           1.243343 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.003146 |           0.043544 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.070214 |           0.067645 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004515 |           0.006073 |
+----------------------------------------+-----------+--------------------+

TravisBuddy · 2020-05-28T18:03:06Z

Travis tests have failed

Hey @priyawadhwa,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.13.8.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.13.8.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.10.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.10.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="8958ea137f333236b2cdaf2db743044a754375f2"" ./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.26.0'
golangci/golangci-lint info found version: 1.26.0 for v1.26.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
WARN [runner] Can't run linter unused: buildssa: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/start_stop_delete_test.go:214:50: too few arguments in call to Status /home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/start_stop_delete_test.go:236:49: too few arguments in call to Status /home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/start_stop_delete_test.go:366:54: too few arguments in call to Status /home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/start_stop_delete_test.go:371:51: too few arguments in call to Status /home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/start_stop_delete_test.go:381:53: too few arguments in call to Status /home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/start_stop_delete_test.go:386:51: too few arguments in call to Status] 
WARN [runner] Can't run linter goanalysis_metalinter: assign: failed prerequisites: [[email protected]/minikube/test/integration [k8s.io/minikube/test/integration.test]: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/start_stop_delete_test.go:214:50: too few arguments in call to Status /home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/start_stop_delete_test.go:236:49: too few arguments in call to Status /home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/start_stop_delete_test.go:366:54: too few arguments in call to Status /home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/start_stop_delete_test.go:371:51: too few arguments in call to Status /home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/start_stop_delete_test.go:381:53: too few arguments in call to Status /home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/start_stop_delete_test.go:386:51: too few arguments in call to Status]] 
ERRO Running error: assign: failed prerequisites: [[email protected]/minikube/test/integration [k8s.io/minikube/test/integration.test]: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/start_stop_delete_test.go:214:50: too few arguments in call to Status /home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/start_stop_delete_test.go:236:49: too few arguments in call to Status /home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/start_stop_delete_test.go:366:54: too few arguments in call to Status /home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/start_stop_delete_test.go:371:51: too few arguments in call to Status /home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/start_stop_delete_test.go:381:53: too few arguments in call to Status /home/travis/gopath/src/github.com/kubernetes/minikube/test/integration/start_stop_delete_test.go:386:51: too few arguments in call to Status]] 
Makefile:387: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 3
= go mod ================================================================
ok
= boilerplate ===========================================================
ok
Makefile:271: recipe for target 'test' failed
make: *** [test] Error 4

TravisBuddy Request Identifier: 79398140-a10d-11ea-8dbc-21d9b9d6c42b

minikube-pr-bot · 2020-05-28T18:06:00Z

kvm2 Driver
Times for minikube: [61.673848006 63.341878607000005 66.523300581]
Average time for minikube: 63.84634239800001

Times for Minikube (PR 8154): [64.178267218 59.217210967 65.91576447]
Average time for Minikube (PR 8154): 63.10374755166666

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8154) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.058757 |           0.054526 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019116 |           0.021003 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003098 |           0.003104 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 39.445095 |          39.309820 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 22.410058 |          21.697908 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.200840 |           1.232367 |
| components...                  |           |                    |
| * Enabled addons:              |  0.634445 |           0.715662 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.071689 |           0.065196 |
| configured to use "minikube"   |           |                    |
|                                |  0.003245 |           0.004163 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.467882365999994 26.378219945999998 25.623910527999996]
Average time for minikube: 26.156670946666665

Times for Minikube (PR 8154): [26.960540546 26.782817828999995 27.188744450999998]
Average time for Minikube (PR 8154): 26.97736760866667

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8154) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.072577 |           0.071204 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002479 |           0.002345 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.056612 |           0.059700 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.315305 |           7.486721 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.114456 |           0.116655 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.424863 |          18.035329 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.103522 |           1.134289 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.002621 |           0.002666 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.060674 |           0.063555 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003562 |           0.004905 |
+----------------------------------------+-----------+--------------------+

codecov-commenter · 2020-05-28T18:08:26Z

Codecov Report

Merging #8154 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8154      +/-   ##
==========================================
+ Coverage   34.35%   34.37%   +0.01%     
==========================================
  Files         147      147              
  Lines        9456     9469      +13     
==========================================
+ Hits         3249     3255       +6     
- Misses       5808     5814       +6     
- Partials      399      400       +1

Impacted Files	Coverage Δ
cmd/minikube/cmd/start.go	`13.51% <ø> (-0.22%)`	⬇️
pkg/minikube/machine/fix.go	`38.31% <0.00%> (ø)`
pkg/minikube/machine/start.go	`62.67% <0.00%> (ø)`
pkg/minikube/machine/ssh.go	`44.44% <0.00%> (+1.58%)`	⬆️
cmd/minikube/cmd/ssh.go	`15.00% <0.00%> (+2.50%)`	⬆️
pkg/minikube/cruntime/cruntime.go	`60.60% <0.00%> (+2.54%)`	⬆️

minikube-pr-bot · 2020-05-28T18:25:34Z

kvm2 Driver
Times for minikube: [62.418250719999996 64.24100229199999 65.148570036]
Average time for minikube: 63.935941015999994

Times for Minikube (PR 8154): [60.932249888 64.377975617 62.037485968999995]
Average time for Minikube (PR 8154): 62.44923715800001

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8154) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.060573 |           0.058259 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019508 |           0.018966 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003166 |           0.008697 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.686523 |          40.154240 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 20.943841 |          20.495325 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.201399 |           1.243560 |
| components...                  |           |                    |
| * Enabled addons:              |  0.940238 |           0.395692 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.077871 |           0.069509 |
| configured to use "minikube"   |           |                    |
|                                |  0.002822 |           0.004990 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.603709281000004 26.536328289000004 26.259964008000004]
Average time for minikube: 26.466667192666666

Times for Minikube (PR 8154): [25.153019097000005 25.983420994999992 26.141533469]
Average time for Minikube (PR 8154): 25.759324520333333

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8154) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.074848 |           0.071894 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002404 |           0.002802 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.057222 |           0.055169 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.637146 |           7.368364 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.114361 |           0.110495 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.708896 |          16.693566 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.799979 |           1.389560 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.002568 |           0.002437 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.065360 |           0.059757 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003883 |           0.005281 |
+----------------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-05-28T21:16:33Z

kvm2 Driver
Times for minikube: [65.963951164 64.295528643 62.931034816000015]
Average time for minikube: 64.39683820766668

Times for Minikube (PR 8154): [63.69428047699999 63.961550158 64.097132399]
Average time for Minikube (PR 8154): 63.917654344666666

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8154) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.060124 |           0.057464 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.018579 |           0.019792 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.017240 |           0.004731 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.151708 |          40.368415 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 21.322132 |                    |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.501466 |           1.232021 |
| components...                  |           |                    |
| * Enabled addons:              |  0.243670 |           0.713090 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.075795 |           0.073072 |
| configured to use "minikube"   |           |                    |
|                                |  0.006124 |          21.445462 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [29.646681779000005 25.99579965 26.374173042]
Average time for minikube: 27.338884823666664

Times for Minikube (PR 8154): [26.955066086 27.232749281999997 26.638473627999996]
Average time for Minikube (PR 8154): 26.942096331999995

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8154) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.072670 |           0.074535 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002432 |           0.002788 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.057281 |           0.056658 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.624781 |           7.689880 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.3         |  0.116186 |                    |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 18.423026 |          17.660452 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.775992 |           1.270302 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.201153 |           0.002665 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.059288 |           0.062143 |
| configured to use "minikube"           |           |                    |
|                                        |  0.006077 |           0.007779 |
+----------------------------------------+-----------+--------------------+

Add additional logging to debug old-k8s-version flake

50a2e83

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 14, 2020

k8s-ci-robot requested review from RA489 and sharifelgamal May 14, 2020 21:06

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2020

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 14, 2020

Add additional logs

b00ef3a

fix -A flag, remove flags

aecd5bb

Merge branch 'master' of github.com:kubernetes/minikube into kvm-flake

508e1a9

priyawadhwa force-pushed the kvm-flake branch from ca6fd25 to 4d0f7d5 Compare May 28, 2020 17:58

Skip old-k8s-version on kvm2

a762d58

priyawadhwa force-pushed the kvm-flake branch from 4d0f7d5 to a762d58 Compare May 28, 2020 17:59

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 28, 2020

Bump up major version to 13

fa6c446

priyawadhwa changed the title ~~WIP: Add additional logging to debug old-k8s-version flake~~ Upgrade oldest k8s version supported to 1.13 May 28, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2020

Add info about --force

3b24e6f

medyagh merged commit 77419ee into kubernetes:master May 28, 2020

priyawadhwa deleted the kvm-flake branch May 28, 2020 21:19

fmotrifork mentioned this pull request Jun 2, 2020

minikube 1.11.0 fishworks/fish-food#764

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade oldest k8s version supported to 1.13 #8154

Upgrade oldest k8s version supported to 1.13 #8154

priyawadhwa commented May 14, 2020 •

edited

Loading

k8s-ci-robot commented May 14, 2020

priyawadhwa commented May 14, 2020

minikube-pr-bot commented May 14, 2020

minikube-pr-bot commented May 15, 2020

codecov-io commented May 15, 2020

minikube-pr-bot commented May 15, 2020

TravisBuddy commented May 28, 2020

minikube-pr-bot commented May 28, 2020

codecov-commenter commented May 28, 2020 •

edited

Loading

minikube-pr-bot commented May 28, 2020

minikube-pr-bot commented May 28, 2020

Upgrade oldest k8s version supported to 1.13 #8154

Upgrade oldest k8s version supported to 1.13 #8154

Conversation

priyawadhwa commented May 14, 2020 • edited Loading

k8s-ci-robot commented May 14, 2020

priyawadhwa commented May 14, 2020

minikube-pr-bot commented May 14, 2020

minikube-pr-bot commented May 15, 2020

codecov-io commented May 15, 2020

Codecov Report

minikube-pr-bot commented May 15, 2020

TravisBuddy commented May 28, 2020

Travis tests have failed

1st Build

TravisBuddy Request Identifier: 79398140-a10d-11ea-8dbc-21d9b9d6c42b

minikube-pr-bot commented May 28, 2020

codecov-commenter commented May 28, 2020 • edited Loading

Codecov Report

minikube-pr-bot commented May 28, 2020

minikube-pr-bot commented May 28, 2020

priyawadhwa commented May 14, 2020 •

edited

Loading

codecov-commenter commented May 28, 2020 •

edited

Loading