add new --extra-config option "scheduler" #8147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
cncf-cla: no
|
Welcome @nezorflame! |
|
Hi @nezorflame. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XS
|
Can one of the admins verify this patch? |
k8s-ci-robot
added
cncf-cla: yes
|
CLA signed. |
|
/assign @medyagh |
medyagh
reviewed
May 14, 2020
There was a problem hiding this comment.
while this is a good PR ! I think we could do even better,
instead of waiting to fail the way here, we could detect and return without crashing.
here are options, we could add a helper func in start.go inside ValidateFlags
and we could validate the extra arg is okay. so the users get a faster resonse
|
the second option would make an ErrorType and return that error type for example and the caller can exit.WithUsage("Please ...blahblah") instead of crashing example of using the ErrorType can be found in kverify package |
Codecov Report
@@ Coverage Diff @@
## master #8147 +/- ##
==========================================
- Coverage 35.27% 35.26% -0.02%
==========================================
Files 146 146
Lines 9326 9342 +16
==========================================
+ Hits 3290 3294 +4
- Misses 5637 5649 +12
Partials 399 399
|
k8s-ci-robot
added
size/S
medyagh
requested changes
May 15, 2020
k8s-ci-robot
added
size/L
|
Added a separate public validation func with test and used it inside of the Example output: Not sure about the formatting, would like an opinion here. |
Codecov Report
@@ Coverage Diff @@
## master #8147 +/- ##
==========================================
- Coverage 35.27% 34.44% -0.83%
==========================================
Files 146 147 +1
Lines 9326 9443 +117
==========================================
- Hits 3290 3253 -37
- Misses 5637 5791 +154
Partials 399 399
|
|
@medyagh any chance you'll have some time to re-review this? |
|
@nezorflame do you mind updating the Before and After, we should fail fast Before configuring the cluster and use exit.WithUsage and also could you please pull the master too ? |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
kvm2 Driver |
k8s-ci-robot
added
the
needs-rebase
|
Tests look OK - do you mind resolving the conflict so that this can be merged? |
|
Yup, will do it this week.
…_____________________________
Best regards,
Ilya Danilkin
С уважением,
Илья Данилкин
ср, 24 июн. 2020 г., 21:13 Thomas Strömberg <[email protected]>:
Tests look OK - do you mind resolving the conflict so that this can be
merged?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8147 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5ZZTSPM5BG7DXFRECHJWLRYI63HANCNFSM4NAY7DYQ>
.
|
nezorflame
force-pushed
the
fix-error-msg
branch
from
60f1230
to
b470860
Compare
k8s-ci-robot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nezorflame The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nezorflame
force-pushed
the
fix-error-msg
branch
from
fe1fecf
to
b470860
Compare
|
@tstromberg done, now need to wait for the checks :) |
Travis tests have failedHey @nezorflame, 1st Buildmake testTravisBuddy Request Identifier: 9aefce50-b979-11ea-a74d-ef5d1a577ce8 |
|
kvm2 Driver Times for Minikube (PR 8147): [66.60426911200001 64.890782119 64.736219276] Averages Time Per Log docker Driver Times for Minikube (PR 8147): [26.076823896 27.623987482000004 27.251079315999995] Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 8147): [61.44879126299999 61.968026349 63.620719578999996] Averages Time Per Log docker Driver Times for Minikube (PR 8147): [26.081426583 25.747434673 26.491521845] Averages Time Per Log |
medyagh
changed the title
--extra-config parsing
medyagh
changed the title
medyagh
approved these changes
Jul 7, 2020
There was a problem hiding this comment.
@nezorflame thank you for this PR and your patience while it was under review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error message for the
--extra-configoption parsing for theminikube startcommand (also mentioned in #6689).Seems like it was a simple copy-paste issue in the original commit.
Example:
minikube start --extra-config=kubeProxy.IPTables.SyncPeriod.Duration=5000000000Before (failing during the process of setup):
After (validation check during the initialization):