Add defaults subcommand to minikube config
#8143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 13, 2020 14:15
`minikube config defaults PROPERTY_NAME` will print out all acceptable default values for that property. Currently only works for `minikube config defaults driver` which looks like this on Mac: ``` $ minikube config defaults driver * virtualbox * parallels * vmwarefusion * hyperkit * vmware * docker * podman ``` This will be useful for clients that depend on minikube, like IDE extensions.
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #8143 +/- ##
==========================================
+ Coverage 35.27% 35.36% +0.09%
==========================================
Files 146 147 +1
Lines 9326 9364 +38
==========================================
+ Hits 3290 3312 +22
- Misses 5637 5651 +14
- Partials 399 401 +2
|
afbjorklund
previously requested changes
May 14, 2020
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
kvm2 Driver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minikube config defaults PROPERTY_NAMEwill print out all acceptable default values for that property.Currently only works for
minikube config defaults driverwhich looks like this on Mac:Fixes #8127
cc @kschaab