Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker/podman solution message for non-amd64 archs #8053

Merged
merged 5 commits into from
May 11, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented May 9, 2020

adds solution message for #7818

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 9, 2020
@medyagh
Copy link
Member Author

medyagh commented May 9, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 9, 2020
@medyagh medyagh changed the title docker/podman fail on non-amd64 systems docker/podman solution message for non-amd64 archs May 9, 2020
@codecov-io
Copy link

Codecov Report

Merging #8053 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8053   +/-   ##
=======================================
  Coverage   35.45%   35.45%           
=======================================
  Files         146      146           
  Lines        9284     9284           
=======================================
  Hits         3292     3292           
  Misses       5592     5592           
  Partials      400      400           

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [64.725705574 64.428646839 66.20345338800001]
Average time for minikube: 65.11926860033334

Times for Minikube (PR 8053): [66.40791925799999 63.566395699 66.50985464399999]
Average time for Minikube (PR 8053): 65.49472320033333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8053) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on   |  0.060968 |           0.062962 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.019599 |           0.021715 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003057 |           0.002997 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.664172 |          40.015952 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.1 | 22.484352 |          23.060468 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.263225 |           1.826498 |
| components...                  |           |                    |
| * Enabled addons:              |  0.538079 |           0.421696 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.082470 |           0.075838 |
| configured to use "minikube"   |           |                    |
|                                |  0.003346 |           0.006599 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.669738657 27.998681190999996 24.863307149]
Average time for minikube: 26.510575665666664

Times for Minikube (PR 8053): [24.663112963999996 25.723673588999997 27.111487269000005]
Average time for Minikube (PR 8053): 25.832757940666667

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8053) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on           |  0.077911 |           0.070410 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002348 |           0.002465 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.058077 |           0.056977 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.567597 |           7.418157 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.1         |  0.121136 |           0.122553 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.255915 |          16.914174 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.353432 |           1.173194 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.002481 |           0.002648 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.066804 |           0.067109 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004874 |           0.005072 |
+----------------------------------------+-----------+--------------------+

@medyagh medyagh requested a review from afbjorklund May 9, 2020 07:18
Copy link
Collaborator

@afbjorklund afbjorklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we could specify container runtime versions, it's a pain to keep it updated (as we have seen)
Unofficially I think we need to "support" both Podman 1.6.x and 1.8.2, as well as latest/greatest 1.7/1.9

But this was supposedly most about amd64 (x86_64), and seems like a good start! ("requirements")
We should probably eventually also add something similar to the minikube installation instructions...

@medyagh medyagh requested a review from afbjorklund May 11, 2020 19:29
@medyagh
Copy link
Member Author

medyagh commented May 11, 2020

thanks @afbjorklund addressed the review comments, please take another look.

@medyagh medyagh merged commit 12122f7 into kubernetes:master May 11, 2020
@afbjorklund
Copy link
Collaborator

Looks good to me! I think it will be easier to do kicbase for other arch, then to do the minikube.iso

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [74.86718838799999 64.18773868099998 66.427860279]
Average time for minikube: 68.49426244933332

Times for Minikube (PR 8053): [69.63799666799999 67.08838369499999 70.572978842]
Average time for Minikube (PR 8053): 69.09978640166666

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8053) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on   |  0.071261 |           0.066810 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.025919 |           0.026029 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.006198 |           0.003807 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 42.966709 |          42.906571 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.1 | 23.026075 |          23.852262 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.629183 |           1.693252 |
| components...                  |           |                    |
| * Enabled addons:              |  0.682374 |           0.461948 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.082582 |           0.082000 |
| configured to use "minikube"   |           |                    |
|                                |  0.003962 |           0.007105 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.883824005 30.135935858 28.070158531999994]
Average time for minikube: 28.696639465

Times for Minikube (PR 8053): [28.136288295999996 28.384200143999998 28.856486365000002]
Average time for Minikube (PR 8053): 28.458991601666668

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8053) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on           |  0.086793 |           0.088192 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.004083 |           0.003823 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.073657 |           0.066761 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  8.610675 |           8.636061 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.1         |  0.186706 |           0.139648 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 18.598255 |          18.441585 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.925471 |           0.993436 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.134882 |           0.004172 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.072340 |           0.079927 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003779 |           0.005387 |
+----------------------------------------+-----------+--------------------+

@medyagh medyagh deleted the arm64_docker_solution branch March 2, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants