-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker/podman solution message for non-amd64 archs #8053
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #8053 +/- ##
=======================================
Coverage 35.45% 35.45%
=======================================
Files 146 146
Lines 9284 9284
=======================================
Hits 3292 3292
Misses 5592 5592
Partials 400 400 |
kvm2 Driver Times for Minikube (PR 8053): [66.40791925799999 63.566395699 66.50985464399999] Averages Time Per Log
docker Driver Times for Minikube (PR 8053): [24.663112963999996 25.723673588999997 27.111487269000005] Averages Time Per Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we could specify container runtime versions, it's a pain to keep it updated (as we have seen)
Unofficially I think we need to "support" both Podman 1.6.x and 1.8.2, as well as latest/greatest 1.7/1.9
But this was supposedly most about amd64
(x86_64), and seems like a good start! ("requirements")
We should probably eventually also add something similar to the minikube installation instructions...
thanks @afbjorklund addressed the review comments, please take another look. |
Looks good to me! I think it will be easier to do kicbase for other arch, then to do the minikube.iso |
kvm2 Driver Times for Minikube (PR 8053): [69.63799666799999 67.08838369499999 70.572978842] Averages Time Per Log
docker Driver Times for Minikube (PR 8053): [28.136288295999996 28.384200143999998 28.856486365000002] Averages Time Per Log
|
adds solution message for #7818