Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait to add aliases to /etc/hosts before starting kubelet #8035

Merged
merged 19 commits into from
May 8, 2020
Merged

Wait to add aliases to /etc/hosts before starting kubelet #8035

merged 19 commits into from
May 8, 2020

Commits on May 7, 2020

  1. Restart kubeadm on soft minikube start 

    This should resolve a race condition in which the expected node IP and the ip passed into kubelet are different.

This should fix the embed-certs integration test which has been flaky for a while.
    Priya Wadhwa committed May 7, 2020
    Configuration menu
    Copy the full SHA
    c037a97 View commit details
    Browse the repository at this point in the history

  2. Add comments

    Priya Wadhwa committed May 7, 2020
    Configuration menu
    Copy the full SHA
    a353d56 View commit details
    Browse the repository at this point in the history

  3. Restart kubelet in a function that is called on soft start

    Priya Wadhwa committed May 7, 2020
    Configuration menu
    Copy the full SHA
    163ab88 View commit details
    Browse the repository at this point in the history

  4. Restart kubelet if soft start

    Priya Wadhwa committed May 7, 2020
    Configuration menu
    Copy the full SHA
    8ac4281 View commit details
    Browse the repository at this point in the history

  5. Add kic

    Priya Wadhwa committed May 7, 2020
    Configuration menu
    Copy the full SHA
    69a39c1 View commit details
    Browse the repository at this point in the history

  6. remove unnecessary code

    Priya Wadhwa committed May 7, 2020
    Configuration menu
    Copy the full SHA
    ced1914 View commit details
    Browse the repository at this point in the history

  7. move into separate function

    Priya Wadhwa committed May 7, 2020
    Configuration menu
    Copy the full SHA
    8096094 View commit details
    Browse the repository at this point in the history

  8. Add start/stop test for plain old docker

    Priya Wadhwa committed May 7, 2020
    Configuration menu
    Copy the full SHA
    fce7562 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2020

  1. Add host alias back after restarting kubelet

    Priya Wadhwa committed May 8, 2020
    Configuration menu
    Copy the full SHA
    9348667 View commit details
    Browse the repository at this point in the history

  2. Start kubelet after host aliases have been set in /etc/hosts 

    kubelet manages the value of `/etc/hosts` within running containers (e.g. kube-controller-manager). It takes this file from the host, but this causes a race condition between:

1. Us updating /etc/hosts with aliases on IP changes
1. kubelet starting k8s with current value of /etc/hosts

This change removes automatically starting kubelet when systemd comes up. Instead, we start it immediately after making our updates to `/etc/hosts`
    Priya Wadhwa committed May 8, 2020
    Configuration menu
    Copy the full SHA
    73d15fc View commit details
    Browse the repository at this point in the history

  3. Restart kubelet after updating config files 

    This makes sure the kubelet picks up the correct IP
    Priya Wadhwa committed May 8, 2020
    Configuration menu
    Copy the full SHA
    826fb2b View commit details
    Browse the repository at this point in the history

  4. Remove Enable(kubelet) from unpause 

    This way, we won't ever enable kubelet to start when systemd starts, preventing a race condition with `/etc/hosts`
    Priya Wadhwa committed May 8, 2020
    Configuration menu
    Copy the full SHA
    0fa2499 View commit details
    Browse the repository at this point in the history

  5. make it impossible to enable the kubelet service

    Priya Wadhwa committed May 8, 2020
    Configuration menu
    Copy the full SHA
    f574852 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' of https://github.com/kubernetes/minikube into … 

    …embed-certs
    Priya Wadhwa committed May 8, 2020
    Configuration menu
    Copy the full SHA
    ba26770 View commit details
    Browse the repository at this point in the history

  7. Add unit test

    Priya Wadhwa committed May 8, 2020
    Configuration menu
    Copy the full SHA
    cb4dc30 View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary restart

    Priya Wadhwa committed May 8, 2020
    Configuration menu
    Copy the full SHA
    6d1d07c View commit details
    Browse the repository at this point in the history

  9. Remove unnecessary function

    Priya Wadhwa committed May 8, 2020
    Configuration menu
    Copy the full SHA
    753dc44 View commit details
    Browse the repository at this point in the history

  10. Copy files directly now that we control kubeadm

    Priya Wadhwa committed May 8, 2020
    Configuration menu
    Copy the full SHA
    bfef99b View commit details
    Browse the repository at this point in the history

  11. Remove test

    Priya Wadhwa committed May 8, 2020
    Configuration menu
    Copy the full SHA
    2915aaf View commit details
    Browse the repository at this point in the history