virtualbox: Quiet initial ssh timeout warning #8027
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XS
| @@ -438,7 +438,7 @@ func trySSH(h *host.Host, ip string) error { | |||
| d := net.Dialer{Timeout: 3 * time.Second} | |||
| conn, err := d.Dial("tcp", sshAddr) | |||
| if err != nil { | |||
| out.WarningT("Unable to verify SSH connectivity: {{.error}}. Will retry...", out.V{"error": err}) | |||
| glog.Warningf("dial failed (will retry): %v", err) | |||
There was a problem hiding this comment.
if this only causes UI trouble on virtualbox what if we supress UI error only for virtualbox driver? and let other drivers bug us if that happens?
There was a problem hiding this comment.
I feel like adding another branch would be over-complicating things with little benefit. If it fails later, an error will be emitted by the ssh runner.
Codecov Report
@@ Coverage Diff @@
## master #8027 +/- ##
=======================================
Coverage 35.78% 35.78%
=======================================
Files 143 143
Lines 9171 9171
=======================================
Hits 3282 3282
Misses 5489 5489
Partials 400 400
|
On VirtualBox, this issue is apparently a lot more common than I thought.
Fixes #8011