-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addons: fix initial retry delay, double maximum limit #7999
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #7999 +/- ##
=======================================
Coverage 36.04% 36.04%
=======================================
Files 144 144
Lines 9196 9196
=======================================
Hits 3315 3315
Misses 5480 5480
Partials 401 401
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do u mind putting in the PR description what u are trying to solve by increasing the time out? and do u have any good evidence increasing the time out might fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with skepticism. merge only if confident this is not a duck tape.
Updated PR description. |
Fixes #7719