Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kic base image to the cluster config #7985

Merged
merged 2 commits into from
May 4, 2020
Merged

Add kic base image to the cluster config #7985

merged 2 commits into from
May 4, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented May 3, 2020

this PR will get rid of global viper.GetString("base-image")
this PR is a prerequisite for this PR:
#7943 (comment)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 3, 2020
@medyagh medyagh mentioned this pull request May 3, 2020
Merged
@medyagh medyagh requested a review from tstromberg May 3, 2020 02:42
@medyagh medyagh changed the title add kic base image to the cluster config Add kic base image to the cluster config May 3, 2020
@medyagh
Copy link
Member Author

medyagh commented May 3, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 3, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
docker Driver

@codecov-io
Copy link

Codecov Report

Merging #7985 into master will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7985      +/-   ##
==========================================
- Coverage   36.04%   36.04%   -0.01%     
==========================================
  Files         144      144              
  Lines        9196     9199       +3     
==========================================
+ Hits         3315     3316       +1     
- Misses       5480     5482       +2     
  Partials      401      401
Impacted Files Coverage Δ
cmd/minikube/cmd/start_flags.go 50.97% <33.33%> (-0.18%) ⬇️

@medyagh medyagh merged commit 9c77eda into kubernetes:master May 4, 2020
@fmotrifork fmotrifork mentioned this pull request May 12, 2020
Merged
@medyagh medyagh deleted the no_global_viper_baseimg branch March 2, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@medyagh @k8s-ci-robot @minikube-pr-bot @codecov-io @tstromberg