Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tunnel cleanup flag default to true for auto tunnel cleanup #7946

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Change tunnel cleanup flag default to true for auto tunnel cleanup #7946

merged 1 commit into from
Apr 30, 2020

Conversation

govargo
Copy link
Contributor

@govargo govargo commented Apr 30, 2020

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR change minikube tunnel's cleanup flag default to true.
Before this PR, if users have problem(like conflict) with minikube tunnel, users had to execute minikube tunnel --cleanup manually.
After this PR, minikube tunnel auto cleanup those error something.

Which issue(s) this PR fixes:

Fix #7900

Does this PR introduce a user-facing change?

Yes. This PR change minikube tunnel default behavior.

Before this PR

2 step is needed.

# 1. minikube tunnel has an error
$ minikube tunnel
Status:	
	machine: minikube
	pid: 764782
	route: 10.96.0.0/12 -> 172.17.0.2
	minikube: Running
	services: []
    errors: 
		minikube: no errors
		router: conflicting route: 10.96.0.0/12 via 172.17.0.3 dev docker0 
		loadbalancer emulator: no errors

# 2. cleanup manually
$ minikube tunnel --cleanup

After this PR

# 1. minikube tunnel clenup automatically
$ minikube tunnel
Status:	
	machine: minikube
	pid: 764782
	route: 10.96.0.0/12 -> 172.17.0.2
	minikube: Running
	services: []
    errors: 
		minikube: no errors
		router: no errors
		loadbalancer emulator: no errors

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 30, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @govargo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: govargo
To complete the pull request process, please assign afbjorklund
You can assign the PR to them by writing /assign @afbjorklund in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@govargo govargo added the area/tunnel Support for the tunnel command label Apr 30, 2020
@govargo
Copy link
Contributor Author

govargo commented Apr 30, 2020

/assign @afbjorklund

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #7946 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7946   +/-   ##
=======================================
  Coverage   35.71%   35.71%           
=======================================
  Files         149      149           
  Lines        9408     9407    -1     
=======================================
  Hits         3360     3360           
+ Misses       5644     5643    -1     
  Partials      404      404           
Impacted Files Coverage Δ
cmd/minikube/cmd/tunnel.go 5.26% <100.00%> (+0.13%) ⬆️

@medyagh
Copy link
Member

medyagh commented Apr 30, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 30, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
docker Driver

@medyagh medyagh merged commit 25ca347 into kubernetes:master Apr 30, 2020
@govargo govargo deleted the change-tunnel-cleanup-default branch February 13, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tunnel Support for the tunnel command cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tunnel: needs clean after delete router: conflicting route: 10.96.0.0/12 via 172.17.0.3 dev docker0
7 participants