docker-env: fall back to bash if can not detect shell. #7887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
medyagh
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/S
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
medyagh
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
/retest-this-please |
|
kvm2 Driver |
medyagh
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
afbjorklund
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while making a github action bot for minikube, I was trying to use docker-env functionality,
I realized github action shell is NOT detectable, even though it is bash.
because it doesn't give you SHELL environment variable.
I even set shell: bash expclicitly but still minikube cant detect it
https://github.com/k8sguard/discover/blob/master/.github/workflows/main.yml#L17
I think it is better for minikube to fall back to bash instead of crashing and not doing anything. and more users will be able to use minikube in github actions and environments like that.
closes #7886
closes #6766