-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing source directory for podman cni config #7845
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #7845 +/- ##
=======================================
Coverage 35.57% 35.57%
=======================================
Files 148 148
Lines 9297 9297
=======================================
Hits 3307 3307
Misses 5593 5593
Partials 397 397 |
/ok-to-test |
Do we have any tests for this ? |
once jenkins is finished u can test the locally with this ISO |
Of course I missed the copy/paste too, uploaded another fixed and rebased commit. |
kvm2 Driver |
does it work locally ? |
Not tested |
For some reason this got lost with previous commit
This time the build passed (also verified locally).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for verifying locally. looks good to me.
For some reason this got lost with previous commit 46df921
Fixes #7840