Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve "Deploying apps" section of "Getting Started" guide #7748

Merged
merged 5 commits into from
Apr 18, 2020
Merged

Improve "Deploying apps" section of "Getting Started" guide #7748

merged 5 commits into from
Apr 18, 2020

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Apr 17, 2020 •
edited
Loading

Preview: https://deploy-preview-7748--kubernetes-sigs-minikube.netlify.app/docs/start/

NodePorts:

  • Recommend using kubectl get services to poke around
  • Recommend kubectl port-forward alternative instead of minikube ip (the latter won't work in D4D)

LoadBalancer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2020
@medyagh medyagh changed the title Getting started: improve LoadBalancer text site: Getting started: improve LoadBalancer text Apr 17, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 17, 2020
@tstromberg tstromberg changed the title site: Getting started: improve LoadBalancer text site: Improve "Deploying apps" text Apr 17, 2020
@tstromberg tstromberg changed the title site: Improve "Deploying apps" text Improve "Deploying apps" section of "Getting Started" guide Apr 17, 2020
medyagh
medyagh approved these changes Apr 18, 2020
View reviewed changes
site/content/en/docs/start/_index.md Outdated

```shell
minikube service hello-minikube
```

Alternatively, you can find the cluster IP as seen by your host:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure this instruction is correct for kic on platforms with need port fowartd too (docker on mac, windows)

@medyagh medyagh merged commit 6f09ab0 into master Apr 18, 2020
@medyagh medyagh deleted the tstromberg-patch-1 branch May 2, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tstromberg @k8s-ci-robot @medyagh