Upgrade minimum supported k8s version to v1.12 #7723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 16, 2020 11:28
I think this may be creating a race condition and causing TestStartStop to fail, since we seem to be copying over some certs in UpdateCluster.
k8s-ci-robot
added
do-not-merge/work-in-progress
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
medyagh
requested changes
Apr 16, 2020
|
kvm2 Driver Times for Minikube (PR 7723): [63.42998201899999 64.050537614 63.711255984000005] Averages Time Per Log docker Driver Times for Minikube (PR 7723): [25.240080007000003 25.60352289 25.727880578] Averages Time Per Log |
k8s-ci-robot
added
size/L
|
kvm2 Driver Times for Minikube (PR 7723): [61.690081624 64.99763299399999 60.58878878000001] Averages Time Per Log docker Driver Times for Minikube (PR 7723): [25.618497805999997 26.710137192 26.53495615] Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 7723): [63.960688520999994 61.431970304000004 65.338161071] Averages Time Per Log docker Driver Times for Minikube (PR 7723): [25.660940914 24.976913125999996 25.339073459999998] Averages Time Per Log |
priyawadhwa
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Codecov Report
@@ Coverage Diff @@
## master #7723 +/- ##
==========================================
- Coverage 36.22% 36.11% -0.12%
==========================================
Files 148 148
Lines 9217 9215 -2
==========================================
- Hits 3339 3328 -11
- Misses 5488 5495 +7
- Partials 390 392 +2
|
|
kvm2 Driver Times for Minikube (PR 7723): [64.852346336 64.95869502700002 62.503016899] Averages Time Per Log docker Driver Times for Minikube (PR 7723): [26.329752643 25.438378344 26.140624827] Averages Time Per Log |
medyagh
approved these changes
Apr 17, 2020
tstromberg
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7720 #7541
First, I reverted code to run update cluster and setupCerts in sequence to avoid the race condition mentioned here: #7541 (comment)
The TestStartStop/group/old-docker test was also failing because it was running k8s v1.11.10 which relies on kubeadm template version v1alpha1. v1alpha1 doesn't allow us to set parameters to prevent a DiskPressure error, and so this test was failing because the node was constantly under DiskPressure.
Upgrading to v1.12.0 as minimum supported version, which uses kubeadm template v1alpha3, fixes this issue, as it does allow us to set the necessary parameters.