-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve reliability of cluster role binding creation for containerd/cri-o #7705
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #7705 +/- ##
=======================================
Coverage 36.48% 36.48%
=======================================
Files 147 147
Lines 9162 9162
=======================================
Hits 3343 3343
Misses 5430 5430
Partials 389 389 |
kvm2 Driver |
kvm2 Driver Times for Minikube (PR 7705): [61.989271297 62.693295879000004 63.06047126000001] Averages Time Per Log
docker Driver Times for Minikube (PR 7705): [24.659860347 24.371438987999998 25.65662209] Averages Time Per Log
|
/ok-to-test |
Docker Test: TestStartStop/group/old-docker TestStartStop/group/containerd TestStartStop/group/crio
|
closes #7704
Why this PR ?
Integration Test Flake
To fix flakes like this:
https://storage.googleapis.com/minikube-builds/logs/7611/d3db795/Docker_Linux.html#fail_TestStartStop%2fgroup%2fcontainerd
what was happening ?
we tried to apply kic overlay network and enable addons and Elevate System Permissions in Parallel. we need default service account before creating things on minikube.
which drivers are affected by this PR ?
Future PRS ?
users reported same error for when they enabled addons on virtualbox
#7613
we need to refactor enable addons, in a way that it always ensures the Default SA is created. it could be part of Bootstrapper Interface.