Add registry addon feature for docker on mac/windows #7603

alonyb · 2020-04-11T00:06:43Z

This PR is for #7535

Only in Mac/Windows on KIC this is the output.

Rubens-MacBook-Pro:ruben-minikube-act rubendario$ out/minikube start --addons=registry  --vm-driver=docker
😄  minikube v1.9.2 on Darwin 10.15.3
✨  Using the docker driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating Kubernetes in docker container with (CPUs=2) (6 available), Memory=1998MB (1998MB available) ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
E0416 20:24:39.187173   21722 kubeadm.go:319] Overriding stale ClientConfig host https://127.0.0.1:32812 with https://127.0.0.1:32820
❗  This container is having trouble accessing https://k8s.gcr.io
💡  To pull new external images, you may need to configure a proxy: https://minikube.sigs.k8s.io/docs/reference/networking/proxy/
🌟  Enabling addons: default-storageclass, registry, storage-provisioner
💡  Registry addon on with docker uses 32821 please use that instead of default 5000
📘  For more information see: https://minikube.sigs.k8s.io/docs/drivers/docker
🏄  Done! kubectl is now configured to use "minikube"

Output:

k8s-ci-robot · 2020-04-11T00:06:51Z

Hi @alonyb. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-04-11T00:07:03Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alonyb
To complete the pull request process, please assign ra489
You can assign the PR to them by writing /assign @ra489 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pkg/addons/addons.go

minikube-bot · 2020-04-11T00:12:02Z

Can one of the admins verify this patch?

pkg/addons/addons.go

pkg/drivers/kic/kic.go

documentation

Update docker.md

medyagh

seem comments.

site/content/en/docs/drivers/docker.md

… into w/add-registery-addon

TravisBuddy · 2020-04-16T14:53:31Z

Travis tests have failed

Hey @alonyb,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 0829ed00-7ff2-11ea-a591-33c228b1c119

medyagh · 2020-04-16T22:44:17Z

/ok-to-test

minikube-pr-bot · 2020-04-16T23:09:48Z

kvm2 Driver
Times for minikube: [64.45842167800001 63.775620553 61.94562623099999]
Average time for minikube: 63.393222820666665

Times for Minikube (PR 7603): [63.09915510499999 63.879845221000004 63.826361764]
Average time for Minikube (PR 7603): 63.60178736333333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7603) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.058148 |           0.054449 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019606 |           0.017696 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.002995 |           0.004528 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.184063 |          40.488262 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 20.042297 |          21.005905 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.015871 |           1.963172 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.066898 |           0.062653 |
| configured to use "minikube"   |           |                    |
|                                |  0.003343 |           0.005122 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [25.617870710000002 26.23362715 24.837606510999997]
Average time for minikube: 25.563034790333333

Times for Minikube (PR 7603): [24.222345756000003 24.267185732999998 26.296727185]
Average time for Minikube (PR 7603): 24.928752891333332

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7603) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.072271 |           0.070929 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002754 |           0.002560 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.057179 |           0.055135 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.209284 |           7.333300 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000192 |           0.000161 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 16.712380 |          16.027891 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Enabling addons:                     |  1.439183 |           1.370489 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.066344 |           0.063796 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003448 |           0.004492 |
+----------------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-17T00:40:20Z

kvm2 Driver
Times for minikube: [62.800491517999994 64.517715726 64.435331241]
Average time for minikube: 63.91784616166667

Times for Minikube (PR 7603): [64.31170485599999 63.511321812 63.518253224999995]
Average time for Minikube (PR 7603): 63.780426631000005

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7603) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.057285 |           0.055748 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.018813 |           0.018329 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.009816 |           0.002839 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.107825 |          40.470763 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 20.501273 |          21.357709 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.153860 |           1.799097 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.064852 |           0.072338 |
| configured to use "minikube"   |           |                    |
|                                |  0.004123 |           0.003604 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [25.133833431999996 24.507434946 26.35227459]
Average time for minikube: 25.331180989333337

Times for Minikube (PR 7603): [23.046477247 25.416571617000002 27.458543809999995]
Average time for Minikube (PR 7603): 25.307197558

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7603) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.074334 |           0.077437 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.001925 |           0.002187 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.055045 |           0.055543 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.286893 |           7.436134 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000143 |           0.000169 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 16.751299 |          16.646738 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Enabling addons:                     |  1.095426 |           1.024992 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.063317 |           0.059127 |
| configured to use "minikube"           |           |                    |
|                                        |  0.002801 |           0.004870 |
+----------------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-17T01:00:05Z

kvm2 Driver
Times for minikube: [64.082336439 64.241338382 63.150274116999995]
Average time for minikube: 63.82464964599999

Times for Minikube (PR 7603): [64.594298549 63.675055674 62.801884367999996]
Average time for Minikube (PR 7603): 63.690412863666666

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7603) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.054813 |           0.055394 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020131 |           0.018385 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.004752 |           0.013183 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.636447 |          40.917971 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 20.953165 |          20.506711 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.085253 |           2.105353 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.066154 |           0.069345 |
| configured to use "minikube"   |           |                    |
|                                |  0.003933 |           0.004071 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [25.438243104 27.301919042999998 25.942251474000003]
Average time for minikube: 26.227471206999997

Times for Minikube (PR 7603): [25.375156414 26.359010874 25.531028623]
Average time for Minikube (PR 7603): 25.755065303666665

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7603) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.070930 |           0.069990 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002255 |           0.002151 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.053925 |           0.052414 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.258380 |           7.415961 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000168 |           0.000171 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.611517 |          16.660623 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Enabling addons:                     |  1.163894 |           1.489191 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.062733 |           0.060089 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003667 |           0.004475 |
+----------------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-17T01:41:18Z

kvm2 Driver
Times for minikube: [63.334520681 63.97826185899999 62.37886073200001]
Average time for minikube: 63.23054775733333

Times for Minikube (PR 7603): [64.059044793 63.849663973 63.572789532]
Average time for Minikube (PR 7603): 63.82716609933333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7603) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.053440 |           0.058274 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019610 |           0.019684 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.006883 |           0.004921 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.360862 |          40.580587 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 21.070370 |          21.159780 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  1.643359 |           1.923079 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.073082 |           0.075440 |
| configured to use "minikube"   |           |                    |
|                                |  0.002942 |           0.005401 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [24.712241046 26.461028920999997 25.612047453000002]
Average time for minikube: 25.595105806666666

Times for Minikube (PR 7603): [25.478499490999997 25.305843879999994 25.295407432999994]
Average time for Minikube (PR 7603): 25.35991693466666

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7603) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.074201 |           0.070560 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002393 |           0.002421 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.056282 |           0.057018 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.308864 |           7.374266 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000163 |           0.000229 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 16.720444 |          16.481850 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Enabling addons:                     |  1.369583 |           1.307904 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.059342 |           0.062063 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003833 |           0.003606 |
+----------------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-17T02:00:40Z

kvm2 Driver
Times for minikube: [64.15177538100001 59.77629846600001 64.557632985]
Average time for minikube: 62.828568944000004

Times for Minikube (PR 7603): [63.560487265 61.733120754 62.82873433899999]
Average time for Minikube (PR 7603): 62.70744745266666

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7603) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.053853 |           0.053666 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.018100 |           0.020307 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.004365 |           0.002846 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 39.299832 |          40.787921 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 21.271517 |          20.156728 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.110041 |           1.613629 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.066731 |           0.068556 |
| configured to use "minikube"   |           |                    |
|                                |  0.004131 |           0.003794 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [25.139449781999996 24.291971912999998 24.763711897999997]
Average time for minikube: 24.731711197666666

Times for Minikube (PR 7603): [25.530326429 24.818172682 25.651925609]
Average time for Minikube (PR 7603): 25.33347490666667

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7603) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.070049 |           0.072578 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002221 |           0.002466 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.053751 |           0.059944 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.296804 |           7.267107 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000182 |           0.000188 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 16.142744 |          16.816018 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Enabling addons:                     |  1.097674 |           1.043349 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.062409 |           0.066733 |
| configured to use "minikube"           |           |                    |
|                                        |  0.005875 |           0.005092 |
+----------------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-17T19:28:12Z

kvm2 Driver
Times for minikube: [61.30259391999999 63.705150704000005 63.070465049999996]
Average time for minikube: 62.692736558

Times for Minikube (PR 7603): [61.14687640599999 67.86599335700001 62.392238875]
Average time for Minikube (PR 7603): 63.801702879333334

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7603) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.055203 |           0.056497 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019320 |           0.017596 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.002818 |           0.002943 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.106066 |          40.791989 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 20.325734 |          20.916134 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.115926 |           1.943717 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.064160 |           0.068611 |
| configured to use "minikube"   |           |                    |
|                                |  0.003510 |           0.004215 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [25.203978269 24.746630269 24.653950275000003]
Average time for minikube: 24.868186271

Times for Minikube (PR 7603): [25.562342911 25.367611718000003 26.617442934000003]
Average time for Minikube (PR 7603): 25.849132521

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7603) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.070712 |           0.071629 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002317 |           0.002366 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.056379 |           0.055154 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.362359 |           7.214347 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000193 |           0.000162 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 16.444217 |          17.292947 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Enabling addons:                     |  0.866033 |           1.147436 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.061787 |           0.058551 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004189 |           0.006542 |
+----------------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-17T23:57:41Z

kvm2 Driver
Times for minikube: [64.460355538 66.642752898 62.04540387899999]
Average time for minikube: 64.38283743833334

Times for Minikube (PR 7603): [62.732414602000006 65.782731854 65.388474019]
Average time for Minikube (PR 7603): 64.63454015833332

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7603) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.055196 |           0.058042 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020167 |           0.020954 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.002970 |           0.002809 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.705374 |          40.788232 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 21.547324 |          21.467846 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  1.957643 |           2.204408 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.091019 |           0.085601 |
| configured to use "minikube"   |           |                    |
|                                |  0.003144 |           0.006649 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [25.837861551 25.709604867000003 26.490933026]
Average time for minikube: 26.012799814666664

Times for Minikube (PR 7603): [24.821625769000004 25.845501355 26.251828668]
Average time for Minikube (PR 7603): 25.63965193066667

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7603) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.075260 |           0.071808 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002219 |           0.002409 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.054979 |           0.056001 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.444317 |           7.157063 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000171 |           0.000178 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 16.995322 |          17.084217 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Enabling addons:                     |  1.374818 |           1.199609 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.063107 |           0.063506 |
| configured to use "minikube"           |           |                    |
|                                        |  0.002605 |           0.004862 |
+----------------------------------------+-----------+--------------------+

site/content/en/docs/drivers/docker.md

medyagh · 2020-04-17T00:26:01Z

pkg/addons/addons.go

+			if err != nil {
+				return errors.Wrap(err, "registry port")
+			}
+			out.T(out.Documentation, `Registry addon on with {{.driver}} uses {{.port}} please use that.


change this to two lines
out.T(out.Tip, Registry addon on with {{.driver}} uses {{.port}} please use that instead of default 500.)
out.T(out.Documentation, For more information see: https://minikube.sigs.k8s.io/docs/drivers/{{.driver}})

also make sure the link says {{.driver}} not docker

pkg/addons/addons.go

medyagh · 2020-04-17T00:37:58Z

pkg/addons/addons.go

@@ -176,6 +178,17 @@ https://github.com/kubernetes/minikube/issues/7332`, out.V{"driver_name": cc.Dri
 		return nil
 	}

+	if name == "registry" {
+		if driver.IsKIC(cc.Driver) && runtime.GOOS != "linux" {
+			port, err := kic.GetRegistryAddonPort(cc)


6
also get rid of
func GetRegistryAddonPort(cc *config.ClusterConfig) (int, error)

insead of that just directly call the oci.ForwardedPort(cc.Driver, cc.Name, constants.RegistryAddonPort)
it is a one line thing

minikube-pr-bot · 2020-04-18T01:56:41Z

kvm2 Driver
Times for minikube: [64.50067151399999 67.99851880399999 64.379645965]
Average time for minikube: 65.626278761

Times for Minikube (PR 7603): [62.323305223000006 64.509571439 63.15886923299999]
Average time for Minikube (PR 7603): 63.33058196499999

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7603) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.057724 |           0.053962 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019242 |           0.017850 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003214 |           0.003011 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.550518 |          40.660709 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.757448 |          20.752787 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.159155 |           1.773829 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.075752 |           0.064648 |
| configured to use "minikube"   |           |                    |
|                                |  0.003226 |           0.003786 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [25.506515402 27.262730914 26.812234481999997]
Average time for minikube: 26.527160266

Times for Minikube (PR 7603): [26.237618879 26.547181863999995 25.82037073]
Average time for Minikube (PR 7603): 26.201723824333328

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7603) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.070636 |           0.068328 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002212 |           0.001911 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.055671 |           0.054975 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.234152 |           7.287890 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000163 |           0.000170 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 18.258356 |          17.599179 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Enabling addons:                     |  0.839722 |           1.122377 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.062329 |           0.060842 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003920 |           0.006051 |
+----------------------------------------+-----------+--------------------+

ruben-baez-seagull-com added 10 commits April 10, 2020 08:19

add registery port constant

e785012

add oci port mapping of registery

50c2ec4

add new addon

428d9ee

add return port logic

c4ef1b3

add addon struct

79593cb

change output message

3bd1430

remove driver and use clusterConfig

201a2bb

change constant name

f48d2ca

add KIC validation

6f34183

remove test code

01e0237

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 11, 2020

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 11, 2020

k8s-ci-robot requested review from medyagh and priyawadhwa April 11, 2020 00:07

medyagh reviewed Apr 11, 2020

View reviewed changes

pkg/addons/addons.go Outdated Show resolved Hide resolved

medyagh reviewed Apr 11, 2020

View reviewed changes

pkg/addons/addons.go Outdated Show resolved Hide resolved

medyagh reviewed Apr 11, 2020

View reviewed changes

pkg/addons/addons.go Outdated Show resolved Hide resolved

medyagh reviewed Apr 11, 2020

View reviewed changes

pkg/drivers/kic/kic.go Outdated Show resolved Hide resolved

ruben-baez-seagull-com added 4 commits April 10, 2020 20:09

Update docker.md

e636272

Merge pull request #4 from alonyb/patch-1

d372027

documentation

Update docker.md

a9e87bd

Merge pull request #5 from alonyb/change-documentation

3d6b945

Update docker.md

medyagh reviewed Apr 11, 2020

View reviewed changes

site/content/en/docs/drivers/docker.md Outdated Show resolved Hide resolved

ruben-baez-seagull-com added 3 commits April 11, 2020 00:56

some adjustments

4f86c3e

Merge branch 'w/add-registery-addon' of github.com:RubenBaez/minikube…

4417ac8

… into w/add-registery-addon

Update docker.md

bd5fd81

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 16, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 16, 2020

fix registry addon template

59e9c83

medyagh mentioned this pull request Apr 17, 2020

feature: add doc URL to the addon list table #7731

Closed

add docker inspect command

d573b6c

delete unnecesary func

bfa45ef

delete links

5ec1862

ruben-baez-seagull-com added 2 commits April 16, 2020 20:47

update registry_addon_mac_windows.inc

2f940d8

fix docker commands

40e87af

change upper case & add new step

6bde0e0

fix documentation

cef7a6f

change table of pushing doc

c48b22b

medyagh approved these changes Apr 18, 2020

View reviewed changes

delete windows and mac doc

a96d8f0

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 18, 2020

medyagh merged commit 825ba53 into kubernetes:master Apr 18, 2020

medyagh mentioned this pull request Apr 18, 2020

add registery addon feature for docker on mac/windows #7535

Closed

alonyb mentioned this pull request Jun 12, 2020

REQUEST: New membership for @alonyb kubernetes/org#1929

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add registry addon feature for docker on mac/windows #7603

Add registry addon feature for docker on mac/windows #7603

alonyb commented Apr 11, 2020 •

edited

Loading

k8s-ci-robot commented Apr 11, 2020

k8s-ci-robot commented Apr 11, 2020

minikube-bot commented Apr 11, 2020

medyagh left a comment

TravisBuddy commented Apr 16, 2020

medyagh commented Apr 16, 2020

minikube-pr-bot commented Apr 16, 2020

minikube-pr-bot commented Apr 17, 2020

minikube-pr-bot commented Apr 17, 2020

minikube-pr-bot commented Apr 17, 2020

minikube-pr-bot commented Apr 17, 2020

minikube-pr-bot commented Apr 17, 2020

minikube-pr-bot commented Apr 17, 2020

medyagh Apr 17, 2020

medyagh Apr 17, 2020

minikube-pr-bot commented Apr 18, 2020

Add registry addon feature for docker on mac/windows #7603

Add registry addon feature for docker on mac/windows #7603

Conversation

alonyb commented Apr 11, 2020 • edited Loading

k8s-ci-robot commented Apr 11, 2020

k8s-ci-robot commented Apr 11, 2020

minikube-bot commented Apr 11, 2020

medyagh left a comment

Choose a reason for hiding this comment

TravisBuddy commented Apr 16, 2020

Travis tests have failed

TravisBuddy Request Identifier: 0829ed00-7ff2-11ea-a591-33c228b1c119

medyagh commented Apr 16, 2020

minikube-pr-bot commented Apr 16, 2020

minikube-pr-bot commented Apr 17, 2020

minikube-pr-bot commented Apr 17, 2020

minikube-pr-bot commented Apr 17, 2020

minikube-pr-bot commented Apr 17, 2020

minikube-pr-bot commented Apr 17, 2020

minikube-pr-bot commented Apr 17, 2020

medyagh Apr 17, 2020

Choose a reason for hiding this comment

medyagh Apr 17, 2020

Choose a reason for hiding this comment

minikube-pr-bot commented Apr 18, 2020

alonyb commented Apr 11, 2020 •

edited

Loading