Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallback to alternate drivers on failure #7389

Merged
merged 22 commits into from
Apr 9, 2020
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
ac1b3b0
merge
sharifelgamal Apr 2, 2020
357b5bb
Merge branch 'master' of github.com:kubernetes/minikube into driver-f…
sharifelgamal Apr 2, 2020
26c7471
failback to alternate drivers if startup fails with automatic choice
sharifelgamal Apr 2, 2020
af8d01d
Merge branch 'master' of github.com:kubernetes/minikube into driver-f…
sharifelgamal Apr 2, 2020
dd957ff
make sure to print error on failure
sharifelgamal Apr 2, 2020
b66447e
remove random failure for testing
sharifelgamal Apr 2, 2020
31f225d
fix lint
sharifelgamal Apr 2, 2020
3d037a8
only failback to next driver if provisioning fails
sharifelgamal Apr 4, 2020
66f9e13
Merge branch 'master' of github.com:kubernetes/minikube into driver-f…
sharifelgamal Apr 4, 2020
f290aa9
Merge branch 'master' of github.com:kubernetes/minikube into driver-f…
sharifelgamal Apr 6, 2020
78595b1
split out node provisioning and starting kubernetes
sharifelgamal Apr 6, 2020
eb42d16
actually error out when driver is specified
sharifelgamal Apr 6, 2020
81ac4d2
Merge branch 'master' of github.com:kubernetes/minikube into driver-f…
sharifelgamal Apr 7, 2020
5df9ead
never exit during provisioning
sharifelgamal Apr 7, 2020
45bf65c
Merge branch 'master' of github.com:kubernetes/minikube into driver-f…
sharifelgamal Apr 8, 2020
c40a942
Merge branch 'master' of github.com:kubernetes/minikube into driver-f…
sharifelgamal Apr 9, 2020
aee3c1d
Merge branch 'master' into driver-fallback
tstromberg Apr 9, 2020
d2dbf53
fix node name regression
sharifelgamal Apr 9, 2020
198247d
make alternate driver text more clear
sharifelgamal Apr 9, 2020
e4b4a5a
Merge branch 'master' of github.com:kubernetes/minikube into driver-f…
sharifelgamal Apr 9, 2020
9853274
fix build failure
sharifelgamal Apr 9, 2020
322b5d5
fix build errors for realsies this time
sharifelgamal Apr 9, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/minikube/node/start.go
Original file line number Diff line number Diff line change
@@ -113,7 +113,8 @@ func Start(starter Starter, apiServer bool) (*kubeconfig.Settings, error) {
// setup kubeadm (must come after setupKubeconfig)
bs = setupKubeAdm(starter.MachineAPI, *starter.Cfg, *starter.Node)
err = bs.StartCluster(*starter.Cfg)
if err != nil {

if err != nil {
out.LogEntries("Error starting cluster", err, logs.FindProblems(cr, bs, *starter.Cfg, starter.Runner))
return nil, err
}
You are viewing a condensed version of this merge commit. You can view the full changes here.