-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move errors and warnings to output to stderr #7382
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Error: running mkcmp: exit status 1 |
Codecov Report
@@ Coverage Diff @@
## master #7382 +/- ##
=======================================
Coverage 37.18% 37.19%
=======================================
Files 145 145
Lines 8836 8850 +14
=======================================
+ Hits 3286 3292 +6
- Misses 5154 5161 +7
- Partials 396 397 +1
|
All Times Minikube (PR 7382): [ 62.940264 62.596238 64.452249] Average minikube: 63.526305 Averages Time Per Log
|
All Times minikube: [ 65.015572 63.226705 65.156055] Average minikube: 64.466111 Averages Time Per Log
|
following failures for for docker driver need confirmation PR reply that is not related to this PR.
|
Errors appear unrelated. |
Fixes issue where we inadvertently pollute JSON output with "slow docker" warning: #7381