Remove vendored kube2sky, Add kube-dns as cluster addon #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 33.95% (diff: 100%)@@ master #738 diff @@
==========================================
Files 43 42 -1
Lines 1975 1820 -155
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 618 618
+ Misses 1228 1073 -155
Partials 129 129
|
| @@ -51,7 +50,7 @@ func NewLocalkubeServer() *localkube.LocalkubeServer { | |||
| // AddFlags adds flags for a specific LocalkubeServer | |||
| func AddFlags(s *localkube.LocalkubeServer) { | |||
| flag.BoolVar(&s.Containerized, "containerized", s.Containerized, "If kubelet should run in containerized mode") | |||
| flag.BoolVar(&s.EnableDNS, "enable-dns", s.EnableDNS, "If dns should be enabled") | |||
| flag.BoolVar(&s.EnableDNS, "enable-dns", s.EnableDNS, "DEPRECATED: Please run kube-dns as an cluster addon") | |||
There was a problem hiding this comment.
Should we just remove this flag? It seems as though it does nothing now. Just a suggestion though, either way seems fine.
EDIT: Talked about this offline, flag is there for compatibility with previous versions of localkube
|
@minikube-bot test this please |
Closed
|
Would you mind rebasing onto master and rerunning tests? |
|
Rebased, test rerunning now |
Removes the vendored in kube2sky built into the minikube binary and replaces the dns solution with kube-dns cluster addon. This will allow users to swap out DNS implementations by simply turning off the kube-dns addon.
These were referenced by kube2sky and our dns implementation
|
This should fix #55 by making it obsolete. |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the vendored in kube2sky built into the minikube binary and
replaces the dns solution with kube-dns cluster addon. This will allow
users to swap out DNS implementations by simply turning off the
kube-dns addon.
TBD: How to handle older localkube versions?
These versions will try to run their own DNS unless
--enable-dns=falseis passed into localkube. This will conflict with the addon's clusterIP.Proposed fix in this PR
I deprecated the flag in newer versions of localkube, and made minikube always pass in
enable-dns=false. This will be a no-op in new versions of localkube and disable DNS in favor of the cluster addon in older versions. We won't need to rebuild any old versions of localkube, but are stuck with a deprecated flag.PTAL a look at the first commit which contains the changes. The second is only removing the unused vendor packages.
Fixes #55