Run dashboard with internal kubectl if not in path #7299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #7299 +/- ##
==========================================
- Coverage 37.47% 37.43% -0.04%
==========================================
Files 146 146
Lines 8870 8879 +9
==========================================
Hits 3324 3324
- Misses 5141 5150 +9
Partials 405 405
|
afbjorklund
force-pushed
the
dashboard-kubectl
branch
from
74d79f6
to
6d53c00
Compare
tstromberg
approved these changes
Mar 28, 2020
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
Error: running mkcmp: exit status 1 |
medyagh
approved these changes
Mar 29, 2020
|
I think the name "mustload" is quite ugly. Maybe should accept a kubernetes "version" instead ? func KubectlCommand(co mustload.ClusterController, args ...string) (*exec.Cmd, error) {
version := co.Config.KubernetesConfig.KubernetesVersion |
afbjorklund
force-pushed
the
dashboard-kubectl
branch
from
6d53c00
to
5b423ab
Compare
If "kubectl" is not in the PATH, then use the same cached binary as with the "minikube kubectl" command (version matching cluster).
afbjorklund
force-pushed
the
dashboard-kubectl
branch
from
5b423ab
to
5f95150
Compare
tstromberg
approved these changes
Apr 1, 2020
|
Tested this locally and it ran great. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If "kubectl" is not in the PATH, then use the same cached binary
as with the "minikube kubectl" command (version matching cluster).
Closes #7290