-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show all global flags in options command #7292
Conversation
Hi @linkvt. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: linkvt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Before this fix the flags shown in `minikube options` were taken from a list of options (`viperWhiteList`) which seems arbitrary. I still don't know for sure why this is done but taking all PersistentFlags (persistent=apply to all sub commands) from the root command seems like the correct way.
Can one of the admins verify this patch? |
/ok-to-test |
Error: running mkcmp: exit status 1 |
@linkvt thank you for fixing this ! |
Fixes #5117
Before this fix the flags shown in
minikube options
were taken from a list of options (viperWhiteList
) which seems a bit arbitrary to me with no background.I still don't know for sure why this is done but taking all PersistentFlags (persistent=apply to all sub commands) from the root command seems like the correct way.
This doesn't fix the problem as described in the issue but keeps it consistent with e.g. kubectl, which also shows global flags only with the
options
command.Before
After