Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Docker "slow" timeouts to 15s #7268

Merged
merged 2 commits into from
Mar 26, 2020

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Mar 26, 2020

Fixes #7193

How it appears in the UI:

❗  Executing "docker inspect -f {{.State.Status}} minikube" took an unusually long time: 4.7s
💡  Restarting the docker service may improve performance.

How it appears in logs when a command takes too long:

I0326 14:02:47.539046   85877 fix.go:105] recreateIfNeeded on minikube: state=Error err="docker inspect -f {{.State.Status}} minikube" timed out after 15s

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@tstromberg tstromberg requested a review from medyagh March 26, 2020 21:05
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 26, 2020
@tstromberg tstromberg changed the title Make slow command detection consistent across kic/oci Increase Docker "slow" timeouts to 15s Mar 26, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 65.394817 61.743194 63.599114]
All Times Minikube (PR 7268): [ 65.501850 65.823783 61.540245]

Average minikube: 63.579042
Average Minikube (PR 7268): 64.288626

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7268) |
+----------------------+-----------+--------------------+
| minikube v           |  0.206425 |           0.207044 |
| Creating kvm2        | 39.965813 |          40.889064 |
| Preparing Kubernetes | 21.834722 |          21.587320 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the go.sum changes legit ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker flake: Unable to get machine status: state: inspect <profile> timeout
4 participants