-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sch_tbf and extend filter ipset kernel module for bandwidth shaping #7255
Add sch_tbf and extend filter ipset kernel module for bandwidth shaping #7255
Conversation
Signed-off-by: Yang Keao <[email protected]>
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @YangKeao! |
Hi @YangKeao. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: YangKeao The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/check-cla |
Can one of the admins verify this patch? |
Signed-off-by: Yang Keao [email protected]
There is a strong need for bandwidth shaping/network emulation with specified targets in chaos engineering, for which minikube is a valuable test environment. We are developing
tbf
bandwidth shaping feature for chaos-mesh, and plan to add filter support (specify target pods) in the near future.With these modules,
tc-tbf
andtc-ematch
's ipset feature can work well in minikube now 🍻