Add `(host|control-plane).minikube.internal` to /etc/hosts #7247

tstromberg · 2020-03-26T05:01:31Z

Adds two new hostname aliases that are available to all nodes:

control-plane.minikube.internal - The ControlPlane frontend
host.minikube.internal - The VM Host IP

The first is used so that nodes have consistent connectivity to the apiserver across IP changes. Fixes #7246 -- this means that our configurations do not have to be rewritten when the IP changes.

The second is used so that users have an easier time accessing host services. This will allow us to improve this workflow: https://minikube.sigs.k8s.io/docs/handbook/host-access/

tstromberg · 2020-03-26T05:01:46Z

/ok-to-test

k8s-ci-robot · 2020-03-26T05:02:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-pr-bot · 2020-03-26T05:18:39Z

All Times Minikube (PR 7247): [ 64.669505 73.218519 67.125694]
All Times minikube: [ 70.521201 66.641646 65.125076]

Average minikube: 67.429307
Average Minikube (PR 7247): 68.337906

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7247) |
+----------------------+-----------+--------------------+
| minikube v           |  0.133789 |           0.129782 |
| Creating kvm2        | 42.388797 |          42.984786 |
| Preparing Kubernetes | 22.888186 |          23.233666 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

medyagh · 2020-03-26T05:51:19Z

Docker_Linux — Jenkins: completed with 10 / 30 failures in 3.40 minute(s).

seems much higher than HEAD and it is suspecitous that only lasted 3 mins. maybe need a restart test on a failed machine

sharifelgamal · 2020-03-26T06:11:44Z

The docker tests are panicking on the dashboard test:

22:12:10 2020/03/25 22:12:10 [ERR] GET %2A%20This%20control%20plane%20is%20not%20running%21%20%28state=Stopped%29 request failed: Get %2A%20This%20control%20plane%20is%20not%20running%21%20%28state=Stopped%29: unsupported protocol scheme ""
22:12:10 panic: runtime error: invalid memory address or nil pointer dereference [recovered]
22:12:10 	panic: runtime error: invalid memory address or nil pointer dereference
22:12:10 [signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x14b43b6]
22:12:10 
22:12:10 goroutine 238 [running]:
22:12:10 testing.tRunner.func1(0xc0001f1200)
22:12:10 	/usr/local/go/src/testing/testing.go:874 +0x3a3
22:12:10 panic(0x1643fe0, 0x267ac90)
22:12:10 	/usr/local/go/src/runtime/panic.go:679 +0x1b2
22:12:10 k8s.io/minikube/test/integration.validateDashboardCmd(0x1accb00, 0xc00059e060, 0xc0001f1200, 0xc0002fa0c0, 0x2a)
22:12:10 	/var/lib/jenkins/go/src/k8s.io/minikube/test/integration/functional_test.go:339 +0x2f6
22:12:10 k8s.io/minikube/test/integration.TestFunctional.func3.1(0xc0001f1200)
22:12:10 	/var/lib/jenkins/go/src/k8s.io/minikube/test/integration/functional_test.go:130 +0x97
22:12:10 testing.tRunner(0xc0001f1200, 0xc0002486c0)
22:12:10 	/usr/local/go/src/testing/testing.go:909 +0xc9
22:12:10 created by testing.(*T).Run
22:12:10 	/usr/local/go/src/testing/testing.go:960 +0x350

sharifelgamal · 2020-03-26T06:14:57Z

The test data yaml files need to be changed for the unit tests to pass, those files are easily the most cumbersome things to maintain in this codebase.

pkg/minikube/machine/start.go

medyagh · 2020-03-26T10:02:29Z

/retest-this-please

medyagh · 2020-03-28T05:17:19Z

/retest-this-please

minikube-pr-bot · 2020-04-09T01:09:03Z

Times for minikube: [66.384619117 65.66567577500001 65.211770642]
Average time for minikube: 65.75402184466667

Times for Minikube (PR 7247): [67.97513913600001 64.16424909 67.42762365400002]
Average time for Minikube (PR 7247): 66.52233729333334

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7247) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.054376 |                    |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019992 |           0.019765 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.002970 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.291031 |          40.013649 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.910434 |          24.090348 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.396486 |           2.257739 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.075706 |           0.084656 |
| configured to use "minikube"   |           |                    |
|                                |  0.003026 |           0.051626 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-09T02:36:11Z

Times for minikube: [66.856650408 66.61344204 67.77245690600002]
Average time for minikube: 67.08084978466667

Times for Minikube (PR 7247): [63.757944927 65.967490875 64.989290255]
Average time for Minikube (PR 7247): 64.90490868566667

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7247) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.054164 |                    |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020376 |           0.021040 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003351 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.800076 |          39.771325 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.883999 |          22.873369 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.240990 |           2.103969 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.074419 |           0.076996 |
| configured to use "minikube"   |           |                    |
|                                |  0.003475 |           0.000114 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-09T04:02:21Z

Times for minikube: [67.39853239399999 67.078169953 67.618235001]
Average time for minikube: 67.36497911600001

Times for Minikube (PR 7247): [67.22304196499998 65.049547914 67.788381618]
Average time for Minikube (PR 7247): 66.68699049899999

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7247) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.053897 |                    |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020146 |           0.021075 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003733 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.374293 |          41.407970 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 23.401585 |          22.624123 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.432714 |           2.500336 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.075161 |           0.074599 |
| configured to use "minikube"   |           |                    |
|                                |  0.003451 |           0.000086 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-09T05:27:50Z

Times for minikube: [69.667447457 67.69201342200002 64.361016879]
Average time for minikube: 67.24015925266667

Times for Minikube (PR 7247): [66.66178811 69.179885686 67.70493067799998]
Average time for Minikube (PR 7247): 67.848868158

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7247) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.053452 |                    |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020512 |           0.021640 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.004909 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.309197 |          41.929574 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 23.302497 |          23.724606 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.469350 |           2.047070 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.076776 |           0.068681 |
| configured to use "minikube"   |           |                    |
|                                |  0.003467 |           0.000241 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-09T07:00:28Z

Times for minikube: [69.52041605299999 65.161501013 63.577017164]
Average time for minikube: 66.08631141

Times for Minikube (PR 7247): [67.72041983000001 66.70331142799999 66.64847159500002]
Average time for Minikube (PR 7247): 67.02406761766669

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7247) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.054430 |                    |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019956 |           0.020634 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003557 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.382448 |          41.359629 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.538498 |          23.485389 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.008154 |           2.018473 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.074600 |           0.080500 |
| configured to use "minikube"   |           |                    |
|                                |  0.004669 |           0.000162 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-09T08:34:19Z

Times for minikube: [69.42458749000001 67.02824106000001 65.96256243200003]
Average time for minikube: 67.471796994

Times for Minikube (PR 7247): [65.562912532 66.35343435399999 68.42879403900001]
Average time for Minikube (PR 7247): 66.78171364166667

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7247) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.055046 |                    |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020588 |           0.021299 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003252 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.735415 |          40.533625 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 23.470534 |          23.832205 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.100033 |           2.256619 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.083375 |           0.080139 |
| configured to use "minikube"   |           |                    |
|                                |  0.003552 |           0.000131 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-09T10:00:04Z

Times for minikube: [67.339238802 68.413673488 67.19881655199998]
Average time for minikube: 67.65057628066666

Times for Minikube (PR 7247): [65.37556834300001 67.503662245 64.12870686200002]
Average time for Minikube (PR 7247): 65.66931248333333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7247) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.055207 |                    |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020446 |           0.021671 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003656 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.980088 |          41.180671 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 24.025373 |          21.962043 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.483340 |           2.365793 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.078113 |           0.079590 |
| configured to use "minikube"   |           |                    |
|                                |  0.004352 |           0.056158 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-09T11:25:58Z

Times for minikube: [65.269755022 66.690933757 67.497139295]
Average time for minikube: 66.48594269133334

Times for Minikube (PR 7247): [69.34340876 71.05444056900001 66.714565125]
Average time for Minikube (PR 7247): 69.03747148466665

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7247) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.054800 |                    |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020574 |           0.020672 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003243 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.093116 |          43.194414 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.954946 |          23.356546 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.270743 |           2.330747 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.083447 |           0.076098 |
| configured to use "minikube"   |           |                    |
|                                |  0.005073 |           0.000236 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-09T12:51:52Z

Times for minikube: [67.66677584500002 66.50537875900001 67.101002308]
Average time for minikube: 67.091052304

Times for Minikube (PR 7247): [65.510121122 65.26630127899999 65.748309034]
Average time for Minikube (PR 7247): 65.50824381166666

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7247) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.054458 |                    |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020337 |           0.021342 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003862 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.701556 |          40.066534 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 23.842802 |          22.884654 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.383334 |           2.400449 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.080242 |           0.076055 |
| configured to use "minikube"   |           |                    |
|                                |  0.004461 |           0.003373 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-09T13:57:20Z

Times for minikube: [68.05250180000002 68.579297108 65.881122631]
Average time for minikube: 67.50430717966667

Times for Minikube (PR 7247): [69.928223101 67.930680504 68.855569181]
Average time for Minikube (PR 7247): 68.90482426199999

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7247) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.054035 |                    |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019181 |           0.021971 |
| on user configuration          |           |                    |
| * Starting control plane node  |  0.003264 |                    |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.642569 |          42.363493 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 23.680974 |          24.210818 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.020497 |           2.175008 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.080175 |           0.073936 |
| configured to use "minikube"   |           |                    |
|                                |  0.003612 |           0.000203 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-19T23:47:57Z

kvm2 Driver
Times for minikube: [62.806706447 66.307793549 65.395365673]
Average time for minikube: 64.83662188966667

Times for Minikube (PR 7247): [63.740889460000005 62.598199199999996 62.677469922]
Average time for Minikube (PR 7247): 63.00551952733333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7247) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.058098 |           0.057376 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019483 |           0.018124 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.008024 |           0.004602 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.789621 |          39.800326 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 21.661858 |          21.081860 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  0.001360 |                    |
| Components:                    |           |                    |
|   - verifying node conditions  |  0.000869 |                    |
| ...                            |           |                    |
|   - verifying api server ...   |  0.073161 |                    |
|   - verifying system pods ...  |  1.607656 |                    |
| * Enabled addons:              |  0.522931 |                    |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.089971 |           0.065477 |
| configured to use "minikube"   |           |                    |
|                                |  0.003590 |           0.003159 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [28.082879542 26.48345645399999 25.634686599000002]
Average time for minikube: 26.733674198333333

Times for Minikube (PR 7247): [45.725393477 44.357729586 42.787538997]
Average time for Minikube (PR 7247): 44.29022068666666

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7247) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.069713 |           0.069224 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002297 |           0.002150 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.055636 |           0.000120 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.480509 |                    |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000131 |           0.204214 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 18.077871 |          29.937450 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.001956 |                    |
| Components:                            |           |                    |
|   - verifying node conditions          |  0.001780 |                    |
| ...                                    |           |                    |
|   - verifying api server ...           |  0.104980 |                    |
|   - verifying system pods ...          |  0.869675 |                    |
| * Enabled addons:                      |  0.002545 |                    |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.060620 |           0.076930 |
| configured to use "minikube"           |           |                    |
|                                        |  0.005959 |           0.002820 |
+----------------------------------------+-----------+--------------------+

tstromberg · 2020-04-21T18:17:07Z

This is now ready for code-review!

minikube-pr-bot · 2020-04-21T18:25:20Z

kvm2 Driver
Times for minikube: [64.23176316600001 63.09923532199999 63.13413075100001]
Average time for minikube: 63.488376413000005

Times for Minikube (PR 7247): [65.06252022499999 62.515077121000004 63.52880126099999]
Average time for Minikube (PR 7247): 63.702132869

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7247) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.0 on   |  0.055143 |                    |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.024312 |           0.019921 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003013 |           0.003159 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.350219 |          40.599095 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 21.001821 |          21.000124 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.279740 |                    |
| components...                  |           |                    |
| * Enabled addons:              |  0.691899 |           0.555148 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.077912 |           0.066743 |
| configured to use "minikube"   |           |                    |
|                                |  0.004317 |           0.001296 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [25.807859624000002 24.240411760999997 27.122144601]
Average time for minikube: 25.72347199533333

Times for Minikube (PR 7247): [26.116884622000004 26.269294616 26.369339754]
Average time for Minikube (PR 7247): 26.251839664000002

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7247) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.0 on           |  0.072860 |                    |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002513 |           0.002323 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.054991 |           0.053918 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.370166 |           7.152395 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000153 |           0.110661 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 16.648540 |          17.316513 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.390937 |                    |
| components...                          |           |                    |
| * Enabled addons:                      |  0.116546 |           0.085447 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.063400 |           0.066276 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003366 |           0.070731 |
+----------------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-23T21:46:19Z

kvm2 Driver
Times for minikube: [65.998968871 65.957993868 67.576849282]
Average time for minikube: 66.51127067366667

Times for Minikube (PR 7247): [64.698896823 65.055561857 67.230453205]
Average time for Minikube (PR 7247): 65.661637295

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7247) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.1 on   |  0.061986 |                    |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.020192 |           0.021139 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003715 |           0.003360 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.398746 |          40.873756 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.675320 |          22.329946 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.527424 |           1.407037 |
| components...                  |           |                    |
| * Enabled addons:              |  0.740126 |           0.890867 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.080160 |           0.068735 |
| configured to use "minikube"   |           |                    |
|                                |  0.003602 |           0.003397 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.263577336 26.198404433 27.516310198]
Average time for minikube: 26.659430655666668

Times for Minikube (PR 7247): [27.282102387000002 26.410886307 27.362894135000005]
Average time for Minikube (PR 7247): 27.018627609666666

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7247) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.1 on           |  0.079354 |                    |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002609 |           0.002657 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.060495 |           0.058818 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.875895 |           7.968939 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000271 |           0.121326 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.451830 |          17.779735 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.905676 |           0.896490 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.215697 |           0.038309 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.062663 |           0.069279 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004941 |           0.078608 |
+----------------------------------------+-----------+--------------------+

codecov-io · 2020-04-23T21:48:05Z

Codecov Report

Merging #7247 into master will decrease coverage by 0.04%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##           master    #7247      +/-   ##
==========================================
- Coverage   35.61%   35.57%   -0.05%     
==========================================
  Files         148      148              
  Lines        9303     9314      +11     
==========================================
  Hits         3313     3313              
- Misses       5593     5604      +11     
  Partials      397      397

Impacted Files	Coverage Δ
cmd/minikube/cmd/mount.go	`8.84% <0.00%> (ø)`
cmd/minikube/cmd/status.go	`23.20% <0.00%> (ø)`
pkg/minikube/cluster/ip.go	`0.00% <0.00%> (ø)`
pkg/minikube/machine/start.go	`60.44% <0.00%> (-4.36%)`	⬇️
pkg/minikube/bootstrapper/bsutil/kubeadm.go	`83.56% <100.00%> (ø)`
pkg/minikube/bootstrapper/certs.go	`71.31% <100.00%> (ø)`

tstromberg · 2020-04-24T21:17:27Z

Test failures appear to be due to #7874

Warning  FailedCreatePodSandBox  4m47s                kubelet, containerd-20200424031633-5224  Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "5f9542ae0caf3e5f191eaa74958a13551287d4181f828645772f564dbc74b8f7": unsupported CNI result version "0.4.0"

priyawadhwa

LGTM

medyagh

looks good depending on KVM tests, please merge with upstream, to see the tests results one more time

medyagh · 2020-04-24T22:19:33Z

KVM test looks scary but maybe they will go away if you merge with upstream
https://storage.googleapis.com/minikube-builds/logs/7247/e5cc661/KVM_Linux.html

medyagh · 2020-04-25T23:07:00Z

/retest-this-please

minikube-pr-bot · 2020-04-28T15:24:11Z

Error: running mkcmp
: exit status 1

tstromberg added 2 commits March 25, 2020 21:47

Add hosts aliases for control-plane and VM host

b70115d

apiserver -> control-plane

f756163

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 26, 2020

tstromberg requested a review from sharifelgamal March 26, 2020 05:01

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 26, 2020

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 26, 2020

k8s-ci-robot requested a review from medyagh March 26, 2020 05:02

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020

sharifelgamal reviewed Mar 26, 2020

View reviewed changes

pkg/minikube/machine/start.go Outdated Show resolved Hide resolved

tstromberg changed the title ~~Add hosts aliases for control-plane and VM host~~ Add hosts aliases for control-plane and VM host (DOES NOT BLOCK v1.9) Mar 26, 2020

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2020

tstromberg changed the title ~~Add hosts aliases for control-plane and VM host (DOES NOT BLOCK v1.9)~~ Add hosts aliases for control-plane and VM host Apr 9, 2020

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2020

tstromberg changed the title ~~Add resolvable hostnames for control-plane and VM host~~ WIP: Add resolvable hostnames for control-plane and VM host Apr 20, 2020

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2020

tstromberg added 3 commits April 21, 2020 11:04

Merge branch 'master' into control-plane-host

8336488

Make inability to add host IP non-fatal

b50e816

Add HostIP support for none, reduce tech debt

23fa28f

tstromberg changed the title ~~WIP: Add resolvable hostnames for control-plane and VM host~~ Add "control-plane.minikube.internal" & "host.minikube.internal " to /etc/hosts Apr 21, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 21, 2020

tstromberg changed the title ~~Add "control-plane.minikube.internal" & "host.minikube.internal " to /etc/hosts~~ Add "(host|control-plane).minikube.internal" aliases to /etc/hosts Apr 21, 2020

tstromberg changed the title ~~Add "(host|control-plane).minikube.internal" aliases to /etc/hosts~~ Add "(host|control-plane).minikube.internal" to /etc/hosts Apr 21, 2020

tstromberg changed the title ~~Add "(host|control-plane).minikube.internal" to /etc/hosts~~ Add (host|control-plane).minikube.internal to /etc/hosts Apr 21, 2020

tstromberg added 2 commits April 21, 2020 11:18

Address lint errors

6e2d086

Update examples

bb62005

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 21, 2020

Merge master

e5cc661

priyawadhwa approved these changes Apr 24, 2020

View reviewed changes

medyagh approved these changes Apr 24, 2020

View reviewed changes

medyagh self-requested a review April 24, 2020 22:21

Merge branch 'master' into control-plane-host

878fc6a

tstromberg merged commit 7dc28f6 into kubernetes:master Apr 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `(host|control-plane).minikube.internal` to /etc/hosts #7247

Add `(host|control-plane).minikube.internal` to /etc/hosts #7247

tstromberg commented Mar 26, 2020 •

edited

Loading

tstromberg commented Mar 26, 2020

k8s-ci-robot commented Mar 26, 2020

minikube-pr-bot commented Mar 26, 2020

medyagh commented Mar 26, 2020 •

edited

Loading

sharifelgamal commented Mar 26, 2020

sharifelgamal commented Mar 26, 2020 •

edited

Loading

medyagh commented Mar 26, 2020

medyagh commented Mar 28, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 19, 2020

tstromberg commented Apr 21, 2020 •

edited

Loading

minikube-pr-bot commented Apr 21, 2020

minikube-pr-bot commented Apr 23, 2020

codecov-io commented Apr 23, 2020

tstromberg commented Apr 24, 2020

priyawadhwa left a comment

medyagh left a comment •

edited

Loading

medyagh commented Apr 24, 2020 •

edited

Loading

medyagh commented Apr 25, 2020

minikube-pr-bot commented Apr 28, 2020

Add (host|control-plane).minikube.internal to /etc/hosts #7247

Add (host|control-plane).minikube.internal to /etc/hosts #7247

Conversation

tstromberg commented Mar 26, 2020 • edited Loading

tstromberg commented Mar 26, 2020

k8s-ci-robot commented Mar 26, 2020

minikube-pr-bot commented Mar 26, 2020

medyagh commented Mar 26, 2020 • edited Loading

sharifelgamal commented Mar 26, 2020

sharifelgamal commented Mar 26, 2020 • edited Loading

medyagh commented Mar 26, 2020

medyagh commented Mar 28, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 9, 2020

minikube-pr-bot commented Apr 19, 2020

tstromberg commented Apr 21, 2020 • edited Loading

minikube-pr-bot commented Apr 21, 2020

minikube-pr-bot commented Apr 23, 2020

codecov-io commented Apr 23, 2020

Codecov Report

tstromberg commented Apr 24, 2020

priyawadhwa left a comment

Choose a reason for hiding this comment

medyagh left a comment • edited Loading

Choose a reason for hiding this comment

medyagh commented Apr 24, 2020 • edited Loading

medyagh commented Apr 25, 2020

minikube-pr-bot commented Apr 28, 2020

Add `(host|control-plane).minikube.internal` to /etc/hosts #7247

Add `(host|control-plane).minikube.internal` to /etc/hosts #7247

tstromberg commented Mar 26, 2020 •

edited

Loading

medyagh commented Mar 26, 2020 •

edited

Loading

sharifelgamal commented Mar 26, 2020 •

edited

Loading

tstromberg commented Apr 21, 2020 •

edited

Loading

medyagh left a comment •

edited

Loading

medyagh commented Apr 24, 2020 •

edited

Loading