Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct preload paths on Windows, announce base image pull #7221

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

tstromberg
Copy link
Contributor

Minor fixes to improve feeling of preload on Windows

  • Paths output looked funny because one of the slashes was reversed
  • If the preload had been previously downloaded to support a VM, minikube appeared hung because we never announced a download of kic base image

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 25, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2020
@minikube-pr-bot
Copy link

All Times Minikube (PR 7221): [ 67.294894 67.410008 70.209641]
All Times minikube: [ 67.794229 67.604514 70.199618]

Average minikube: 68.532787
Average Minikube (PR 7221): 68.304848

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7221) |
+----------------------+-----------+--------------------+
| minikube v           |  0.224113 |           0.218059 |
| Creating kvm2        | 43.688535 |          43.717206 |
| Preparing Kubernetes | 22.645728 |          22.243031 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@medyagh medyagh merged commit 1f30cfc into master Mar 25, 2020
@medyagh medyagh deleted the windows-out branch April 17, 2020 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants