wip: wait for Default Service Account

[medyagh]

This Pr will break
minikube start --wait

but the following will still work
minikube start --wait=true (waits for 2 as the current default behavior(
minikube start --wait=false
minikube start --wait=all (waits for 3 components)
minikube start --wait=apiserver,system_pods,default_sa (waits for these 3)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[afbjorklund]

I suppose you could add a separate flag --wait-components, if you worry about backwards compat ?

[medyagh]

I suppose you could add a separate flag --wait-components, if you worry about backwards compat ?

I thought about that, but the thing is, I dont want the default behiavor to include waiting for default service account (that is not needed for 90% of ppl) and adds ups to 30s to start time.

if I had made a components flag, then if I keep the old flag, the True would need to do all of it ?

[k8s-ci-robot]

@medyagh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tstromberg]

It's unclear to me what this breaks if anything?

What do you think of a tiered approach so that folks don't have to worry about new components that are added?

minikube start --wait=false: wait for nothing, same as today
minikube start --wait=responses -- default: no behavioral change from today
minikube start --wait=all -- wait for everything

minikube start --wait=true -- alias for "all" for backwards compatibility

[medyagh]

It's unclear to me what this breaks if anything?

What do you think of a tiered approach so that folks don't have to worry about new components that are added?

minikube start --wait=false: wait for nothing, same as today
minikube start --wait=responses -- default: no behavioral change from today
minikube start --wait=all -- wait for everything

minikube start --wait=true -- alias for "all" for backwards compatibility

sounds like a good idea !
redoing this PR here --wait, wait for more components #7375